Skip to content

Add $toInt, $toDouble, $toLong, $toDecimal tests - #684

Merged
eerxuan merged 18 commits into
documentdb:mainfrom
PatersonProjects:toNumber_tests
Jul 15, 2026
Merged

Add $toInt, $toDouble, $toLong, $toDecimal tests#684
eerxuan merged 18 commits into
documentdb:mainfrom
PatersonProjects:toNumber_tests

Conversation

@PatersonProjects

@PatersonProjects PatersonProjects commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds the tests for $toInt, $toDouble, $toLong, and $toDecimal. It was originally authored by @danielfrankcom.

Ref: Issue #15, #328, #327, #329, #326

@PatersonProjects
Reset to restore to main
40ec48e 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Merge branch 'main' of https://github.com/PatersonProjects/functional…
b73ce4a 
…-tests

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Merge branch 'main' of https://github.com/PatersonProjects/functional…
ec9e7fc 
…-tests

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Merge branch 'main' of https://github.com/PatersonProjects/functional…
1c87758 
…-tests

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Base toDouble Tests
df20a26 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Started parametrization edits
8115270 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
toDouble migrated
b92395a 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Migrated toInt tests
b2fdff0 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Migrated toDecimal tests, added lazy to large string tests and replac…
fa51cef 
…ed magic number with constants

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
migrate: add operator tests to documentdb_tests
8330dd3 
Migrates  tests from old_tests/ to documentdb_tests/compatibility/
tests/core/operator/expressions/type/toLong/ following the migration harness.

Files added:
- __init__.py
- test_smoke_toLong.py (was already present)
- test_toLong_arity.py       (arity + invalid field path)
- test_toLong_numeric.py     (null/missing, bool, int32, int64, double)
- test_toLong_decimal128.py  (Decimal128 truncation and overflow)
- test_toLong_datetime_binary.py (datetime, binary, unsupported types)
- test_toLong_string.py      (string conversion + size limit)
- test_toLong_return_type.py (return type invariant + idempotency)
- test_toLong_field_ref.py   (field references + expression input)

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
migrate: step 1.5 $toLong — refactor rejection tests to bson_type_val…
6599361 
…idator

- Add generate_bson_rejection_test_cases() to test_toLong_return_type.py
  for ObjectId, Regex, Timestamp, JavaScript/Code, MinKey, MaxKey types
- Skip NULL (returns null, not error), OBJECT and ARRAY (need $literal
  wrapping) from generated rejection — keep hand-written cases for those
- Remove the six now-redundant hand-written ExpressionTestCase rejection
  entries from test_toLong_datetime_binary.py
- Drop unused bson imports (Code, MaxKey, MinKey, ObjectId, Regex, Timestamp)

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
migrate: step 3 $toLong — fill two coverage gaps from old suite
08f1d07 
Add two cases missing from the new test suite vs the old:

1. type_code_with_scope: CodeWithScope (BSON 0x0f) is a distinct type from
   JavaScript/Code (0x0d) and is not covered by bson_type_validator samples.
   Verified it produces CONVERSION_FAILURE_ERROR like plain Code.

2. type_nested_array: $toLong([[\x22 42\x22]]) — the outer single-element literal
   array is unwrapped at parse time, leaving the inner [\x2242\x22] (a runtime array)
   as the actual argument, which is a conversion failure.

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
migrate: step 3.5 $toLong — replace inline literals with named constants
565fefa 
Replace three bare numeric literals flagged by find_numerical_constant_replacements.py:
- 0 (int32) -> INT32_ZERO
- 0.5         -> DOUBLE_HALF
- -0.5        -> DOUBLE_NEGATIVE_HALF

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
migrate: step 4 review fixups — promote computed literals to named co…
01f4ca7 
…nstants

framework/test_constants.py:
- Add INT64_FROM_DOUBLE_MAX_FITTING = Int64(9223372036854774784)
  (int64 truncation of DOUBLE_MAX_FITTING_INT64)
- Add DOUBLE_BELOW_INT64_MIN = math.nextafter(-float(2**63), float('-inf'))
  (first IEEE 754 double strictly below int64 min)
- Add 'import math' for the above

test_toLong_numeric.py:
- Replace inline Int64(9223372036854774784) with INT64_FROM_DOUBLE_MAX_FITTING
- Replace math.nextafter(...) expression with DOUBLE_BELOW_INT64_MIN
- Drop now-redundant 'import math'

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
revert: remove DOUBLE_BELOW_INT64_MIN from test_constants
810ec74 
Restore math.nextafter(-float(2**63), FLOAT_NEGATIVE_INFINITY) inline in
test_toLong_numeric.py and remove the constant (and import math) that
were added to test_constants.py in the previous commit.

Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
Parametrized standalone test cases
4acdef8 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@PatersonProjects
PatersonProjects requested a review from a team as a code owner July 14, 2026 15:47
@PatersonProjects PatersonProjects changed the title Add toInt, toDouble, toLong, toDecimal tests Add $toInt, $toDouble, $toLong, $toDecimal tests Jul 14, 2026
danielfrankcom
danielfrankcom reviewed Jul 14, 2026
View reviewed changes
Comment thread ...b_tests/compatibility/tests/core/operator/expressions/type/toDecimal/test_toDecimal_arity.py
Comment thread ...ests/compatibility/tests/core/operator/expressions/type/toDecimal/test_toDecimal_datetime.py Outdated
Comment thread ...sts/compatibility/tests/core/operator/expressions/type/toLong/test_toLong_datetime_binary.py Outdated
Comment thread ..._tests/compatibility/tests/core/operator/expressions/type/toDecimal/test_toDecimal_double.py Outdated
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jul 14, 2026
@documentdb-triage-tool

documentdb-triage-tool Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status Needs Review
Confidence: 0.90 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (5654+0 LOC, 36 files); LLM: Adds compatibility test coverage for four type conversion aggregation operators ($toInt, $toDouble, $toLong, $toDecimal), expanding test suite for tracked issues.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@PatersonProjects
Addressed PR Comments
5bb1e3a 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
@eerxuan
eerxuan merged commit a8ab2da into documentdb:main Jul 15, 2026
20 checks passed
@danielfrankcom danielfrankcom mentioned this pull request Jul 15, 2026
Merged
RyanGarfinkel pushed a commit to RyanGarfinkel/functional-tests that referenced this pull request Jul 20, 2026
@PatersonProjects @danielfrankcom @RyanGarfinkel
Add $toInt, $toDouble, $toLong, $toDecimal tests (documentdb#684)
4972494 
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Co-authored-by: PatersonProjects <keldonhoff@gmail.com>
Co-authored-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: RyanGarfinkel <113050972+RyanGarfinkel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerxuan eerxuan eerxuan approved these changes
+1 more reviewer
@danielfrankcom danielfrankcom danielfrankcom approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PatersonProjects @danielfrankcom @eerxuan