Skip to content

Add $dayOfWeek, $dayOfMonth, $dayOfYear tests - #681

Merged
eerxuan merged 7 commits into
documentdb:mainfrom
danielfrankcom:pr/day-of
Jul 15, 2026
Merged

Add $dayOfWeek, $dayOfMonth, $dayOfYear tests#681
eerxuan merged 7 commits into
documentdb:mainfrom
danielfrankcom:pr/day-of

Conversation

@danielfrankcom

Copy link
Copy Markdown
Collaborator

This change adds tests for the $dayOfWeek, $dayOfMonth, and $dayOfYear expressions. They were originally
authored by @mitchell-elholm.

Closes #312, #313, #314

danielfrankcom and others added 3 commits July 13, 2026 13:36
This change adds tests for the $dayOfMonth expression. It was originally
authored by @mitchell-elholm.

Closes documentdb#312

Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $dayOfWeek expression. It was originally
authored by @mitchell-elholm.

Closes documentdb#313

Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $dayOfYear expression. It was originally
authored by @mitchell-elholm.

Closes documentdb#314

Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
@danielfrankcom
danielfrankcom requested a review from a team as a code owner July 13, 2026 20:41
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jul 13, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status Needs Review
Confidence: 0.90 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (4978+0 LOC, 27 files); LLM: Adds new test coverage for three date expression operators, closing three tracked issues, touching the compatibility tests component.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

Signed-off-by: Daniel Frankcom <frankcom@amazon.com>

@PatersonProjects PatersonProjects left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a couple potential duplicates and a couple potential additions

Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
@eerxuan
eerxuan merged commit b165a8b into documentdb:main Jul 15, 2026
20 checks passed
RyanGarfinkel pushed a commit to RyanGarfinkel/functional-tests that referenced this pull request Jul 20, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Co-authored-by: Daniel Frankcom <frankcom@amazon.com>
Co-authored-by: Mitchell Elholm <mitchell-elholm@users.noreply.github.com>
Signed-off-by: RyanGarfinkel <113050972+RyanGarfinkel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compatibility test for $dayOfMonth

3 participants