Skip to content

preserve rootless mode during cleanup - #325

Merged
crazy-max merged 2 commits into
docker:masterfrom
crazy-max:fix-rootless-cleanup
Sep 15, 2026
Merged

crazy-max merged 2 commits into
docker:masterfrom
crazy-max:fix-rootless-cleanup

Conversation

@crazy-max

Copy link
Copy Markdown
Member

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Comment thread src/main.ts
Comment on lines 101 to 104
const install = new Install({
runDir: stateHelper.runDir
runDir: stateHelper.runDir,
rootless: core.getBooleanInput('rootless')
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be best to avoid having to recreate this object and just use the same as was used for install

@crazy-max
crazy-max merged commit 8e05055 into docker:master Sep 15, 2026
53 checks passed
@crazy-max
crazy-max deleted the fix-rootless-cleanup branch September 15, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants