Skip to content

Correcting PR URL in 17.06.2-ee-4 notes - #5236

Merged
joaofnfernandes merged 1 commit into
docker:masterfrom
ericsmalling:patch-2
Nov 7, 2017
Merged

joaofnfernandes merged 1 commit into
docker:masterfrom
ericsmalling:patch-2

Conversation

@ericsmalling

@ericsmalling ericsmalling commented Nov 7, 2017 •

Copy link
Copy Markdown
Contributor

Proposed changes

Linked URL of PR was incorrect - fixed it.

fixes #5235

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaofnfernandes

Copy link
Copy Markdown
Contributor

Let's ship it then 🚀
@thaJeztah keep in mind that the source of truth for these release notes is docker/docker-ee (private repo). I don't think in this case we need to send a PR upstream, but are you pinged for reviews on that repo / does it make sense for you to be pinged in the future?

@joaofnfernandes
joaofnfernandes merged commit 5d7d669 into docker:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

17.06.2-ee-4 note Serialize IP allocation docker/libnetwork#1788 links to wrong repo

3 participants