Skip to content

Add info about network: host - #4959

Merged
mdlinville merged 2 commits into
docker:masterfrom
mdlinville:4593
Oct 20, 2017
Merged

mdlinville merged 2 commits into
docker:masterfrom
mdlinville:4593

Conversation

@mdlinville

Copy link
Copy Markdown

Fixes #4593

@shin- PTAL

@shin-

shin- commented Oct 13, 2017

Copy link
Copy Markdown
Contributor

@dnephin should probably take a look.

@dnephin dnephin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4593 is wrong, this is not supported by stack deploy with any version. The field is ignored.

@dnephin

dnephin commented Oct 17, 2017 •

Copy link
Copy Markdown
Contributor

There was some support added for network: host but it does not use this field. It should use something like this, which I believe is also supported in v2:

services:
  web:
    ...
    networks:
      hostnet: {}

networks:
  hostnet:
    external:
      name: host
    

@mdlinville

Copy link
Copy Markdown
Author

Thanks @dnephin I have attempted to update the info to be accurate. Can you take another look?

Comment thread compose/compose-file/compose-file-v2.md Outdated

Use the host's networking stack, or no networking. Equivalent to
`docker run --net=host` or `docker run --net=none`. Only used if you use
`docker stack` commands. If you use the `docker compose` command,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose (not docker compose)

Since this is the reference for v2, and v2 is not supported by docker stack commands, do we need this here? It seems like it's only appropriate for the v3 reference.

Comment thread compose/compose-file/index.md Outdated

Use the host's networking stack, or no networking. Equivalent to
`docker run --net=host` or `docker run --net=none`. Only used if you use
`docker stack` commands. If you use the `docker compose` command,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose

@mdlinville
mdlinville merged commit 2eb70ea into docker:master Oct 20, 2017
@mdlinville
mdlinville deleted the 4593 branch October 20, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants