docs: fix arithmetic in build cache GC policy example - #26016
Merged
Merged
Conversation
The GC policy example defines the first policy as "delete records until there's maximum 5GB of stale cache left", then describes a sweep over 11GB of cache (7GB stale, 4GB other) as deleting 5GB and leaving 6GB. Both numbers contradict the policy as defined. Keeping a maximum of 5GB of stale cache means deleting 2GB of the 7GB, which leaves 5GB stale plus 4GB other, for 9GB in total. The 6GB figure only follows from reading the policy as "delete 5GB", which is the opposite of what it says. The example's point is unchanged: 9GB is still under the second policy's 10GB limit, so the second policy does not need to clear any more cache. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TGSfAZyRTEw9qGGzVECGYk Signed-off-by: Sunmin Lee <134378502+sunm2n@users.noreply.github.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
area/build
dvdksn
approved these changes
Sep 4, 2026
dvdksn
left a comment
dvdksn
left a comment
Contributor
There was a problem hiding this comment.
I don't know where my head was when I wrote this the first time, thanks for fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GC policy example in
content/manuals/build/cache/garbage-collection.mddefines the first policy as:
It then walks through a sweep over 11GB of cache (7GB stale, 4GB other) and
concludes:
Both numbers contradict the policy as defined. Keeping a maximum of 5GB of
stale cache means deleting 2GB of the 7GB, which leaves 5GB stale plus 4GB
other, for 9GB in total.
The 6GB figure is internally consistent only with the opposite reading —
"delete 5GB of stale cache", leaving 2GB stale plus 4GB other. That reading is
what the sentence asserts, and it is not what the policy says, so the two
numbers are wrong together rather than independently.
The example's point survives the correction: 9GB is still under the second
policy's 10GB limit, so the second policy does not need to clear any more
cache.
Note for the reporter of #25927: the "delete 2GB" half of the report is right,
but the report also says the "remainder of 6GB" is correct. It isn't —
11GB minus 2GB is 9GB. 6GB only follows from the misreading being corrected
here.
Related issues or tickets
Fixes #25927
Reviews
🤖 Generated with Claude Code
https://claude.ai/code/session_01TGSfAZyRTEw9qGGzVECGYk