engine: storage/mounts freshness - #21420
Merged
Merged
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
Bot
added
area/engine
dvdksn
force-pushed
the
engine-storage-freshness
branch
from
November 13, 2024 14:48
f12ad59 to
f43d4de
Compare
dvdksn
marked this pull request as ready for review
November 13, 2024 14:51
thaJeztah
reviewed
Nov 13, 2024
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
just some first comments; will need to take a closer look later
dvdksn
force-pushed
the
engine-storage-freshness
branch
2 times, most recently
from
November 18, 2024 09:31
28e9388 to
710cae8
Compare
vvoland
reviewed
Nov 25, 2024
vvoland
reviewed
Nov 25, 2024
dvdksn
force-pushed
the
engine-storage-freshness
branch
2 times, most recently
from
November 29, 2024 08:25
7eeb4a0 to
0ace39d
Compare
aevesdocker
previously approved these changes
Nov 29, 2024
thaJeztah
reviewed
Dec 6, 2024
Comment on lines
-30
to
-31
| > Working with large repositories or monorepos, or with virtual file systems that are no longer scaling with your codebase? | ||
| > Check out [Synchronized file shares](/manuals/desktop/features/synchronized-file-sharing.md). It provides fast and flexible host-to-VM file sharing by enhancing bind mount performance through the use of synchronized filesystem caches. |
Member
There was a problem hiding this comment.
Do we still need to refer to the features provided by Docker Desktop? For example, currently we do mention that bind-mounts are created on the daemon host, but it may be relevant to the user that with Docker Desktop we provide extra mechanisms to make that work for host locations (but at a performance penalty for having to bridge / synchronise to the daemon host (VM))
Contributor
Author
There was a problem hiding this comment.
OK, I added this:
diff --git a/content/manuals/engine/storage/bind-mounts.md b/content/manuals/engine/storage/bind-mounts.md
index e00820e90e..4b5d07c09d 100644
--- a/content/manuals/engine/storage/bind-mounts.md
+++ b/content/manuals/engine/storage/bind-mounts.md
@@ -60,6 +60,11 @@ the mount.
If you're using a remote Docker daemon, you can't create a bind mount to
access files on the client machine in a container.
+ For Docker Desktop, the daemon runs inside a Linux VM, not directly on the
+ native host. Docker Desktop has built-in mechanisms that transparently handle
+ bind mounts, allowing you to share native host filesystem paths with
+ containers running in the virtual machine.
+
- Containers with bind mounts are strongly tied to the host.
Bind mounts rely on the host machine's filesystem having a specific directory
Member
There was a problem hiding this comment.
Thanks! Yup, that works for me 👍
thaJeztah
reviewed
Dec 6, 2024
Comment on lines
+58
to
+61
| - Bind mounts are created to the Docker daemon host, not the client. | ||
|
|
||
| If you're using a remote Docker daemon, you can't create a bind mount to | ||
| access files on the client machine in a container. |
Member
There was a problem hiding this comment.
(I probably should've put that previous comment somewhere here)
thaJeztah
reviewed
Dec 6, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
engine-storage-freshness
branch
from
December 6, 2024 13:24
0ace39d to
4838945
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
engine-storage-freshness
branch
from
December 6, 2024 13:39
4838945 to
ba7c7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various freshness updates to improve the flow and structure of the documentation related to storage mounts.
Preview: