Repository navigation
Parsing individual json objects into json array - #5052
Closed
arankeparth wants to merge 1 commit into
Closed
arankeparth wants to merge 1 commit into
arankeparth wants to merge 1 commit into
Conversation
Author
|
This is a slightly dirty fix. please suggest some changes if possible! |
Signed-off-by: parth aranke <arankeparth1912@gmail.com>
Member
|
This would be a breaking change; the current output is line-delimited JSON, which most tools would be able to handle already. |
Contributor
|
I'm going to close this for now; not only is this an undesired breaking change (the output here has always intentionally been JSON lines), but kludging an array together using string manipulation (instead of changing the serialization code) is not a sensible way to make this change even if it was desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added commas between individual json objects and then added brackets around them to make an array.
- How I did it
Read each line from the buffer then added comma and finally added brackets.
- How to verify it
- Description for the changelog
Parsing individual json objects into json array