Add content trust tests for run command - #1596
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
=========================================
Coverage ? 55.25%
=========================================
Files ? 289
Lines ? 19395
Branches ? 0
=========================================
Hits ? 10716
Misses ? 7983
Partials ? 696 |
|
ping @justincormack PTAL |
thaJeztah
added
area/testing
area/trust
status/2-code-review
and removed
status/0-triage
labels
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
two minor nits, but otherwise SGTM (I'll do a quick rebase of the PR to trigger CI again, and will address those nits while I'm doing so)
| func TestUntrustedRun(t *testing.T) { | ||
| dir := fixtures.SetupConfigFile(t) | ||
| defer dir.Remove() | ||
| image := "registry:5000/alpine:untrusted" |
There was a problem hiding this comment.
nit: we should probably use the registryPrefix const here;
Line 16 in 2c4de4f
| } | ||
|
|
||
| func TestTrustedRunFromBadTrustServer(t *testing.T) { | ||
| evilImageName := "registry:5000/evil-alpine:latest" |
Signed-off-by: Guillaume Le Floch <glfloch@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
455e62d to
348f24c
Compare
|
@thaJeztah thank you for the review. I was going to do the modification but you already did them, thanks! |
|
Oops! Wanted to leave a comment that I did that, but forgot 😊 (I had the branch checked out locally, so thought I'd just as well push the change) |
|
Thank you @glefloch for your contribution, especially for adding tests 👍 |
5 participants
Signed-off-by: glefloch glfloch@gmail.com
- What I did
I add two tests on trust content for the
runcommand. This intend to partially close #951- How I did it
I migrated code from the pull request removing the testsuite from moby repository ( TestUntrustedRun and TestTrustedRunFromBadTrustServer)
- How to verify it
You can verify it by running the e2e testsuite
- Description for the changelog
Adding trust test for
runcommand- A picture of a cute animal (not mandatory but encouraged)