Skip to content

build: fix build details link in experimental mode - #2722

Merged
tonistiigi merged 2 commits into
docker:masterfrom
crazy-max:test-details-link-exp
Oct 28, 2024
Merged

tonistiigi merged 2 commits into
docker:masterfrom
crazy-max:test-details-link-exp

Conversation

@crazy-max

@crazy-max crazy-max commented Oct 8, 2024 •

Copy link
Copy Markdown
Member

fixes #2382

Temp workaround while we are working on cleaning up the controller logic.

@crazy-max
crazy-max force-pushed the test-details-link-exp branch 3 times, most recently from 052caaa to a51e219 Compare October 8, 2024 11:39
@crazy-max crazy-max changed the title test: details link support in experimental mode build: fix build details link in experimental mode Oct 8, 2024
@crazy-max
crazy-max marked this pull request as ready for review October 8, 2024 11:48
@crazy-max crazy-max added this to the v0.18.0 milestone Oct 8, 2024
Comment thread controller/errdefs/errdefs.proto Outdated

message Build {
string Ref = 1;
string BuildRef = 2;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference?

@crazy-max crazy-max Oct 8, 2024 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to handle the attached session when monitoring:

ref = be.Ref

will be "local" for local builds:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this "kind" or "type" then?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking a bit more at it, for local builds with controller it always set local but for remote it sets a random id that lives across the controller session:

ref := identity.NewID()

So ref is still good but confusing as this is not a build ref. It's even more confusing as we already have BuildOptions.Ref in

string Ref = 29;

I renamed it to sessionID.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
crazy-max force-pushed the test-details-link-exp branch from 52cddf9 to eb15c66 Compare October 24, 2024 13:37
@crazy-max
crazy-max requested a review from tonistiigi October 24, 2024 13:40
@tonistiigi
tonistiigi merged commit 202c390 into docker:master Oct 28, 2024
@crazy-max
crazy-max deleted the test-details-link-exp branch October 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build details link not displayed in experimental mode

2 participants