Repository navigation
tests: build multiplatform - #2620
Conversation
Signed-off-by: idnandre <andre@idntimes.com>
| cmd := buildxCmd(sb, withDir(dir), withArgs("bake"), withArgs("--set", fmt.Sprintf("*.output=type=image,name=%s,push=true", target))) | ||
| out, err := cmd.CombinedOutput() | ||
|
|
||
| if !isMobyWorker(sb) { |
There was a problem hiding this comment.
@crazy-max how does this check detect whether the docker daemon supports multi-arch? Having a quick look; isMobyWorker and isMobyContainerdSnapWorker look identical, but if docker is running with the containerd image-store enabled, it supports multi-arch?
Lines 97 to 105 in 56cb197
Should we have a supportsMultiArch check instead?
There was a problem hiding this comment.
OH! Nevermind; hasFeature vs !hasFeature 🙈 I missed the ! 🙈 😂
Still, maybe a supportsMultiArch or hasMultiarchSupport could make sense (more descriptive?)
There was a problem hiding this comment.
This is not just multiarch but also cache and oci exporters that are supported with containerd snap:
buildx/driver/docker/driver.go
Lines 92 to 95 in aa35c95
add test build and bake multiplatform (--platform), to improve test coverage based on #1857