build: validate build args and labels - #2040
Merged
Merged
Conversation
crazy-max
force-pushed
the
validate-build-args
branch
from
September 11, 2023 14:48
da2f1fb to
d410839
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
validate-build-args
branch
from
September 11, 2023 14:56
d410839 to
73ea082
Compare
crazy-max
marked this pull request as ready for review
September 11, 2023 15:04
jedevc
approved these changes
Sep 11, 2023
19 of 35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2022
Adds validation for build arguments and labels that must have a key to be consistent with previous implementation of the
buildcommand indocker/cli.We already have this validation for bake when we set new overrides:
buildx/bake/bake.go
Lines 430 to 432 in f6b7a3c
buildx/bake/bake.go
Lines 456 to 458 in f6b7a3c