Skip to content

tests: add basic build progress test - #1925

Merged
jedevc merged 1 commit into
docker:masterfrom
dvdksn:test/build-progress
Jul 3, 2023
Merged

jedevc merged 1 commit into
docker:masterfrom
dvdksn:test/build-progress

Conversation

@dvdksn

@dvdksn dvdksn commented Jul 2, 2023

Copy link
Copy Markdown
Contributor

Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com

I saw #1857 and I thought it would be fun to try writing some tests.

This adds a very basic test for --progress tty and plain.

Feel free to suggest improvements or additions. This is my first code PR.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn
dvdksn force-pushed the test/build-progress branch from c4ca936 to b4c0941 Compare July 2, 2023 19:09
@dvdksn
dvdksn requested a review from jedevc July 3, 2023 07:16
@jedevc

jedevc commented Jul 3, 2023

Copy link
Copy Markdown
Collaborator

We use creak/pty in moby/moby, so I'm happy with the new dependency :)

@jedevc
jedevc merged commit d95f5f8 into docker:master Jul 3, 2023
@dvdksn
dvdksn deleted the test/build-progress branch July 3, 2023 10:30
@crazy-max crazy-max mentioned this pull request Apr 19, 2024
19 of 35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants