Old pip version is still present

[michael-k]

Although pip 8.1.2 is installed in the docker image python:3.5, pip 7.1.2 is still present.

pip 8.1.2 is installed and used:

$ docker run --rm -it python:3.5 pip --version
pip 8.1.2 from /usr/local/lib/python3.5/site-packages (python 3.5)

pip lists an old version of itself as outdated:

$ docker run --rm -it python:3.5 pip list --outdated                       
pip (7.1.2) - Latest: 8.1.2 [wheel]
setuptools (18.2) - Latest: 23.0.0 [wheel]
You are using pip version 7.1.2, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

It sill lies around in site-packages:

$ docker run --rm -it python:3.5 ls /usr/local/lib/python3.5/site-packages/
README  __pycache__  _markerlib  easy_install.py  pip  pip-7.1.2.dist-info  pip-8.1.2.dist-info  pkg_resources  setuptools  setuptools-18.2.dist-info

Regards pypa/pip#3538

[tianon]

Interesting -- I'm not sure this is really pypa/pip#3538, since our official image is built on AUFS (not overlay), and since we do the pip upgrade directly in the same layer that it was originally installed (specifically to avoid issues like this), but I could be mistaken. Is there a flag we're missing on our pip line to make sure it cleans up older artifacts completely?

[michael-k]

I'm not sure this is really pypa/pip#3538

It is, just not because of overlay.

Is there a flag we're missing on our pip line to make sure it cleans up older artifacts completely?

Good idea, it happens due to --ignore-installed

python/3.5/Dockerfile

Line 34 in 9383f7d

&& pip3 install --no-cache-dir --upgrade --ignore-installed pip==$PYTHON_PIP_VERSION \

I removed it locally, built the image and ran the commands again. The errors are gone.

[michael-k]

PR #100 fixes this.

[tianon]

I don't remember why we added --ignore-installed 😞

If it currently works without, that sounds great, and we can cross the bridge of why we added it previously if the problem it solved resurfaces. 👍

Do you know of a simple one-liner we could use to test for the failure case, so that we can embed it directly in the Dockerfile and avoid this issue resurfacing? (it's OK if there's not a simple one -- I'd rather have asked and the answer be "not really" than not have asked at all 😄)

[michael-k]

Here are two tests that work:

RUN test $(ls -1 /usr/local/lib/python3.5/site-packages/ | grep "pip.*dist-info" | wc -l) -eq 1

RUN test $(pip list | grep -o -P '(?<=pip \().*(?=\))') = $PYTHON_PIP_VERSION

I like the second one better.