This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Repository navigation
ps shows healthcheck only for running container - #1675
Merged
Merged
Conversation
ndeloof
force-pushed
the
ps_exitcode
branch
4 times, most recently
from
May 17, 2021 07:53
7889adf to
6bc2845
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
gtardif
approved these changes
May 17, 2021
| {ID: "789", Name: "789", Project: testProject, Service: "service2", State: "Running", Health: "", Publishers: nil}, | ||
| {ID: "123", Name: "123", Project: testProject, Service: "service1", State: "running", Health: "healthy", Publishers: nil}, | ||
| {ID: "456", Name: "456", Project: testProject, Service: "service1", State: "running", Health: "", Publishers: []compose.PortPublisher{{URL: "localhost:80", TargetPort: 90, PublishedPort: 80}}}, | ||
| {ID: "789", Name: "789", Project: testProject, Service: "service2", State: "exited", Health: "", ExitCode: 130, Publishers: nil}, |
Contributor
There was a problem hiding this comment.
You should need compose.PsOptions{All: true} in order to see exited containers here ? Ah no, compose ps --all means show one-off containers, but by default in compose we list exited containers... :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
updated ps output so
Related issue
close #1671
close #1672