Skip to content

Handle Medium request failures #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle Medium request failures #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8fd20a
Handle Medium request failures
dajiaohuang Oct 16, 2026
9bdee0a
Reject malformed story responses
dajiaohuang Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions lib/post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,22 @@ function fetchStories(modifier, value, latest, cb) {
}

request(url, function (err, res) {
if (!err && res.statusCode == 200) {
if (err) {
cb(err);
} else if (res.statusCode == 200) {
// Strip out while(1) prepended to res
var data = JSON.parse(res.body.replace('])}while(1);</x>', ''));
cb(data);
// statusCode is 404 if the user doesn't exist
var data;
try {
data = JSON.parse(res.body.replace('])}while(1);</x>', ''));
} catch (parseError) {
cb(parseError);
return;
}
cb(null, data);
} else if (res.statusCode == 404) {
console.log(value + ' is not a valid Medium author.');
process.exit(1);
cb(new Error(value + ' is not a valid Medium author.'));
} else {
cb(new Error('Medium returned HTTP ' + res.statusCode));
}
});
}
Expand Down Expand Up @@ -125,9 +133,9 @@ function processContent(data, modifier, count) {
function getStories(modifier, options) {
var deferred = Q.defer();
var value = options.value, latest = options.latest;
getContent(modifier, value, latest, function (res) {
if (!res) {
return deferred.reject();
getContent(modifier, value, latest, function (err, res) {
if (err) {
return deferred.reject(err);
}
var posts = processContent(res, modifier, options.count);
deferred.resolve(posts);
Expand Down