Revert shadow-tree commit-lifecycle hooks - #44
Open
piaskowyk wants to merge 1 commit into
Open
Conversation
SzymczakJ
approved these changes
Sep 9, 2026
SzymczakJ
left a comment
SzymczakJ
left a comment
There was a problem hiding this comment.
LGTM, race conditions that were bugging us here are already fixed in reanimated, so we can get rid of it.
This reverts commit 9eee718. The shadowTreeCommitSucceeded / shadowTreeCommitFinalized hooks existed only to make Reanimated's props-registry equality eviction race-free. That eviction turned out to be performance neutral and has been removed from the Reanimated fork, so nothing overrides these hooks anymore and the fork can drop the divergence from upstream in ShadowTree, ShadowTreeDelegate, UIManager and UIManagerCommitHook. Also restores the configureEventEmitterCallback() call in SampleTurboModuleSpec.cpp, which that commit had incidentally commented out. Co-authored-by: Cursor <cursoragent@cursor.com>
piaskowyk
force-pushed
the
piaskowyk/revert-shadow-tree-commit-hooks
branch
from
September 10, 2026 12:45
2a3c841 to
6567776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reverts 9eee718 (
[Android] shadow-tree commit-lifecycle hooks, ported from react-native-archived#100), which addedshadowTreeCommitSucceeded/shadowTreeCommitFinalizedtoShadowTreeDelegateandUIManagerCommitHook, fired them fromShadowTree::tryCommit(via a Discord-onlyScopeGuard/deferhelper) and fanned them out fromUIManager.New measurements show that this change does not affect performance. This PR is part of the props-registry equality eviction of Reanimated updates, which is already solved in a different way inside Reanimated, as well as in Reanimated 4.