Skip to content

[v0.16] Fix NLL compatibility - #649

Merged
sebcrozet merged 1 commit into
dimforge:v0.16from
Mark-Simulacrum:v0.16-nll
Sep 8, 2019
Merged

[v0.16] Fix NLL compatibility#649
sebcrozet merged 1 commit into
dimforge:v0.16from
Mark-Simulacrum:v0.16-nll

Conversation

@Mark-Simulacrum

Copy link
Copy Markdown

Uncovered by a crater run in rust-lang/rust#63565, the most recent v0.16.x version breaks when NLL is fully enabled. This PR is targeted to be based atop tag v0.16.13 (it's probably easiest to merge it manually, unless you want to create a branch for this PR to target).

@est31

est31 commented Sep 8, 2019

Copy link
Copy Markdown
Contributor

See also #561 , #562 and #616 . Interesting that 0.16.x is still used so much in the wild.

@sebcrozet
sebcrozet changed the base branch from dev to v0.16 September 8, 2019 18:44
@sebcrozet

sebcrozet commented Sep 8, 2019

Copy link
Copy Markdown
Member

@Mark-Simulacrum Thank you for this PR! I've created a v0.16 branch which is the new target of this PR. Why is the #![allow(deprecated)] necessary?

@Mark-Simulacrum

Copy link
Copy Markdown
Author

Ah, I think I forgot to drop that, it's not strictly necessary, I can drop it if you'd like.

@sebcrozet

Copy link
Copy Markdown
Member

I can drop it if you'd like.

That would be great!

@Mark-Simulacrum

Copy link
Copy Markdown
Author

Okay, I've dropped the deprecation commit, so this should be good to go. (Closed and reopened because CI failed due to seemingly unrelated -- perhaps network -- reasons).

@sebcrozet

Copy link
Copy Markdown
Member

Thanks! Don't mind the CI. It will fail because of a changes on travis ubuntu version. We fixed our .travis.yml after the 16.x releases.

@sebcrozet
sebcrozet merged commit b015544 into dimforge:v0.16 Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants