test: keep the developer's robot out of the suite - #4103
Closed
KrishnaH96 wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4103 +/- ##
==========================================
- Coverage 78.59% 78.59% -0.01%
==========================================
Files 1460 1460
Lines 138230 138234 +4
Branches 11881 11882 +1
==========================================
- Hits 108642 108640 -2
- Misses 26244 26247 +3
- Partials 3344 3347 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| os.environ.setdefault("ZENOH_SCOUT_ADDR", f"224.0.0.224:{17700 + _BUCKET}") | ||
|
|
||
| # GlobalConfig reads .env itself, so a developer's robot must be blanked, not just unset. | ||
| for _k in ("ROBOT_IP", "ROBOT_IPS", "ZENOH_CONNECT"): |
Contributor
There was a problem hiding this comment.
I think we should ignore everything in .env. I'm checking how it can be done in pytest.
spomichter
marked this pull request as ready for review
September 13, 2026 00:58
spomichter
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0 and
spomichter
as code owners
September 13, 2026 00:58
Contributor
|
Contributor
|
Added an alternative here: #4111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GlobalConfig reads .env itself, so a ROBOT_IP in the checkout makes every zenoh session dial the robot and stall 1 s; 5 async-module tests fail and the suite runs 3x slower.
Solution
conftest blanks ROBOT_IP/ROBOT_IPS/ZENOH_CONNECT before dimos imports; the dotenv precedence test drops them too. Popping is not enough because pydantic-settings reads the file directly.
How to test
19 passed across the six affected files with ROBOT_IP set; 5 failed before.
AI assistance
Used Fable 5.1 extensively for root cause analysis, fix and testing.
Checklist