Skip to content

docs(agent-browser): repoint stale Source-of-truth pointers to the surface controller - #352

Open
dormouse-bot wants to merge 1 commit into
mainfrom
docs/dor-browser-controller-pointers
Open

docs(agent-browser): repoint stale Source-of-truth pointers to the surface controller#352
dormouse-bot wants to merge 1 commit into
mainfrom
docs/dor-browser-controller-pointers

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Three Source of truth: parentheticals in dor-browser.md still credit AgentBrowserPanel.tsx for logic that moved into agent-browser-surface-controller.ts when the panel was reduced to a thin view. The controller's own header comment now claims these responsibilities ("connection + screenshot loop, viewport-sync state machine, pop-out/pop-in orchestration + auto-revert, CDP observer, canonical-URL tracking"), and the spec's own Agent-Browser Connection section already credits the controller — so these three pointers were internally contradictory and out of date.

Repointed to the controller:

  • rememberRestorableUrl / URL mirror (§Render Modes) — now agent-browser-surface-controller.ts:rememberRestorableUrl.
  • screenActions, sync effects, pop-out/pop-in (§Display swaps) — screenActions/popOut/popIn live in the controller.
  • pop-out state, CDP observer, auto-revert (§Pop-out) — CDP observer and maybeAutoRevert live in the controller.

Left untouched: AgentBrowserPanel.tsx references that are still accurate — the panel remains the renderer view (toDevice coordinate mapping, input handlers, DOM focus) and is correctly listed as the agent-browser renderer elsewhere in the spec.

Verified: each moved symbol grep-confirmed absent from AgentBrowserPanel.tsx and present in agent-browser-surface-controller.ts; pnpm lint:specs passes. Docs-only, no test.

Found during the nightly code-quality survey.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32f4a77
Status: ✅  Deploy successful!
Preview URL: https://8421ce2f.mouseterm.pages.dev
Branch Preview URL: https://docs-dor-browser-controller.mouseterm.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant