docs(agent-browser): repoint stale Source-of-truth pointers to the surface controller - #352
Open
dormouse-bot wants to merge 1 commit into
Open
docs(agent-browser): repoint stale Source-of-truth pointers to the surface controller#352dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
32f4a77
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8421ce2f.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-dor-browser-controller.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three
Source of truth:parentheticals indor-browser.mdstill creditAgentBrowserPanel.tsxfor logic that moved intoagent-browser-surface-controller.tswhen the panel was reduced to a thin view. The controller's own header comment now claims these responsibilities ("connection + screenshot loop, viewport-sync state machine, pop-out/pop-in orchestration + auto-revert, CDP observer, canonical-URL tracking"), and the spec's own Agent-Browser Connection section already credits the controller — so these three pointers were internally contradictory and out of date.Repointed to the controller:
rememberRestorableUrl/ URL mirror (§Render Modes) — nowagent-browser-surface-controller.ts:rememberRestorableUrl.screenActions, sync effects, pop-out/pop-in (§Display swaps) —screenActions/popOut/popInlive in the controller.maybeAutoRevertlive in the controller.Left untouched:
AgentBrowserPanel.tsxreferences that are still accurate — the panel remains the renderer view (toDevicecoordinate mapping, input handlers, DOM focus) and is correctly listed as the agent-browser renderer elsewhere in the spec.Verified: each moved symbol grep-confirmed absent from
AgentBrowserPanel.tsxand present inagent-browser-surface-controller.ts;pnpm lint:specspasses. Docs-only, no test.Found during the nightly code-quality survey.