chore(deps): update xterm - #348
Conversation
dormouse-bot
left a comment
dormouse-bot
left a comment
There was a problem hiding this comment.
The lib/ and standalone/ bump itself is clean: versions are consistent across both manifests, @xterm/addon-webgl correctly stays at 0.20.0-beta.291 (no beta.292 was published, and that build's gitHead is already the beta.292 core commit, so its peer on 6.1.0-beta.292 resolves), and CI is green.
One project-health flag, not a blocker on the diff itself. Per docs/specs/webgl-text.md → Following upstream, an @xterm/* bump is the trigger to re-evaluate the SDF fork, and step 1 is checking whether the upstream beta touched addons/addon-webgl. This one did — unlike most betas, which are no-ops for the fork.
The beta.291 → beta.292 range (xtermjs/xterm.js compare) is a single fix — "Fix stale rendering after a shared texture atlas is cleared" (#6055) — and it lands in addons/addon-webgl/src/TextureAtlas.ts, the file the fork extends for SDF. Upstream's addon-webgl@0.20.0-beta.291 already carries it (built from 904ae935); the fork base sdf291.0 (built from 699f5537) does not, so merging this leaves the canopy/ fork one real atlas-clear fix behind the upstream it's compared against in UpstreamVsFork.
The spec's guidance is to rebase/release the fork and bump the canopy/ pins in the same PR so the tree never records lib and the fork disagreeing on the upstream base. That's hand-cut, out-of-repo work (diffplug/xterm.js) I can't do from here — flagging so it's a deliberate call rather than a silent drift. If you'd rather accept the temporary Storybook-only divergence and rebase on your own cadence, this is mergeable as-is.
Evidence
@xterm/xterm@6.1.0-beta.291gitHead:699f5537b0232e444cb98261b8b3991c3cfecb5e@xterm/xterm@6.1.0-beta.292gitHead:904ae935269eef5ec6a1415b64463c3d02eff1eb@xterm/addon-webgl@0.20.0-beta.291gitHead:904ae935269eef5ec6a1415b64463c3d02eff1eb(already has the fix)canopy/package.jsonpins:@diffplug/xterm-addon-webgl-sdfsdf-v0.20.0-sdf291.0(built frombeta.291=699f5537, pre-fix),@xterm/xterm@6.1.0-beta.291- Compare API
files:addons/addon-webgl/src/TextureAtlas.ts,addons/addon-webgl/test/WebglSharedAtlasGarble.test.ts
1 participant
This PR contains the following updates:
0.12.0-beta.291→0.12.0-beta.2920.5.0-beta.291→0.5.0-beta.2926.1.0-beta.291→6.1.0-beta.292Release Notes
xtermjs/xterm.js (@xterm/addon-fit)
v0.12.0-beta.292Compare Source
Configuration
📅 Schedule: (in timezone America/Los_Angeles)
* * * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.