Conversation
Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
|
Selected evidence: Incomplete · 12/12 tests · 18/18 assertions · 8 images Commit Coverage gaps: Required verification: incomplete. Selected evidence does not satisfy all required specs. No authenticated current-head required plan is available. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } from "@openwork/browser-tabs"; | ||
| import { runDetachedTask } from "./process-resilience.mjs"; | ||
| import { listInstalledBrowsers } from "./installed-browsers.mjs"; | ||
| import { registeredNativeAppLinkForHttps } from "./native-app-links.mjs"; |
There was a problem hiding this comment.
UI change without screenshot evidence
The browser link context menu gains a native-app action without a referenced screenshot or recording of the changed surface.
Evidence
browser-panel.mjsimportsregisteredNativeAppLinkForHttps, which is used to add the native-app item to the link context menu.- The provided PR body references implementation research but no PNG, JPG, GIF, or MP4 showing the changed menu.
- The changed surface is the browser link context menu in
browser-panel.mjs.
Identified by Warden · design-spec-review · MKX-BY6
Warden review summary — ClearNative findings: 1. Blocking policy matches before consolidation: 0. Full finding text remains in Warden's native checks and review threads. This comment retains only native IDs, severity, skill attribution, and safe locations. Analysis run Reported trigger coverage (not proof of complete repository or context coverage): diff-security-review (171772 ms), confidentiality-review (196833 ms), spec-provenance-review (134912 ms), desktop-den-sync-review (189756 ms), design-spec-review (204440 ms). Blockers
Advisories
Needs recheck
Observed review-thread metrics
Thread states are read-only collection snapshots. These metrics are neither lifetime totals nor exact resolution times, and this summary is not clearance authority. |
![diff-warden[bot]](https://avatars.githubusercontent.com/u/118544361?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warden security clearance: clear. No blocking findings (security or desktop↔den sync) in this diff (21f5bc1d258cc9fb83ab2528a896819a9ed6a55e). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run
|
Required verification: waiting. Selected evidence is separate. Missing required specs: app-smoke.e2e.test.ts, browser-tabs-owned-by-thread.e2e.test.ts, cross-server-handoff-atomic-commit.e2e.test.ts, desktop-policy-restricted-mode.e2e.test.ts, org-team-lifecycle-critical-path.e2e.test.ts. Commit Scope: critical and changed spec files; excluded and manual dispositions are not passing coverage. |
1 participant
This PR adds an explicit
Open in <registered app>action to website-link context menus when a narrowly supported Notion, Linear, or Slack URL has a locally registered protocol handler. The existing browser and copy choices stay available, policy is checked against the original HTTPS URL, and missing or failing handlers simply omit the new item.It does not change primary clicks, route arbitrary domains, add remembered preferences, or implement true OS/vendor integration. Real vendor-app authentication, target arrival, arbitrary-domain discovery, and real protocol registration on macOS and Windows remain out of scope.
The implementation uses a strict local mapping catalog and Electron protocol-handler lookup, with no network resolution. Slack and Linear forms are vendor documented; the narrow Notion form is third-party-supported rather than an official rewrite API. The research and implementation review records the source summary, rejected alternatives, exact mapping boundaries, and remaining platform limitations.
Screenshots
Before — no handler: the native menu retains browser and copy choices without a native-app item.
After — synthetic registered app: the native popup shows the display name supplied by the in-memory protocol registry. This does not show a vendor app launching.
Verification
progressbarrole errors reproduce on cleandev; this command is not reported as passedThe final evidence is bound to head
21f5bc1d2. Earlier pre-repair runs are diagnostic only and are not claimed as head evidence. The revert run is an intentional negative control, not a passing product run.The E2E witness uses a synthetic protocol registry and intercepts external dispatch. No vendor application was installed or tested, and real macOS/Windows protocol integration remains unverified. Skipped and unselected tests are not passed coverage.