Skip to content

Fix service-page spacing via CSS shim (custom.css) + preserve showEdit=false - #7

Draft
diecasting wants to merge 1 commit into
mainfrom
feat-service-css-spacing-fix
Draft

diecasting wants to merge 1 commit into
mainfrom
feat-service-css-spacing-fix

Conversation

@diecasting

Copy link
Copy Markdown
Owner

Summary

Isolated, minimal fix for cramped service-page section titles and broken card grids across the 7 languages (EN/DE/ES/FR/IT/JA/KO).

Files changed (exactly 2):

  1. assets/css/custom.css — add a self-contained Tailwind-equivalent utility shim (36 classes) covering the utilities the structured service partials use but that are missing from the committed Tailwind v4 compiled main.css (e.g. py-12/sm:py-16, grid-cols-1/lg:grid-cols-3, gaps, dark variants). Restores vertical rhythm and card grids.
  2. config/_default/params.toml — preserve the previously approved showEdit = false (removes visitor-visible edit anchors on service pages).

Root cause: the service section partials were added after assets/css/compiled/main.css was compiled. tailwind.config.js has no content block and CI only runs hugo --minify (no Tailwind rebuild), so 36 utilities were absent from the bundle. This patch is an additive CSS shim only — no partial/template/content/SEO/analytics/config changes, and main.css is not recompiled here.

Verification

  • git diff --check clean; PR contains exactly the 2 files above.
  • Hugo build passes (exit 0) on the branch.
  • 36 utility classes passed static review: all 36 are actually used by the service partials; no orphan classes, no duplicate selectors, no specificity conflicts with main.css (custom.css is bundled last).

Known limitations / out of scope

  • 28/35 service pages were built locally and covered by the spacing check. The die-casting-tooling slug is not built in any of the 7 languages (7 pages) and remains unverified — a build/content gap, not introduced by this patch.
  • mobile de/cnc-machining has a pre-existing horizontal overflow caused by the theme's base text-4xl (36px) rendering a long unbreakable German title; this patch does not modify text-4xl and does not fix it. Recommended as a separate follow-up (e.g. overflow-wrap/hyphens).
  • Verification used DOM computed-style metrics (padding / grid / overflow / anchor count), not pixel-level visual regression.
  • Production is not yet deployed; this is a Draft PR for human review.
  • The Tailwind full recompile fix (scan the service partials and regenerate main.css in CI, then remove this shim) is not part of this PR.

Not authorized in this PR

Merging, deploying, modifying GitHub Actions / Cloudflare / SEO / GA4 / Formspree, or any other files.

- assets/css/custom.css: add 36 Tailwind-equivalent utility classes
  (py-12/sm:py-16, grid-cols-1/lg:grid-cols-3, gaps, dark variants, etc.)
  to restore vertical rhythm and card grids on the structured service
  partials. Root cause: the service section partials were added after the
  committed Tailwind v4 compiled main.css was generated (no content scan,
  no CI Tailwind rebuild), so these utilities were absent from the bundle.
- config/_default/params.toml: preserve the previously approved
  showEdit = false (removes visitor-visible edit anchors on service pages).

Scope is intentionally minimal: CSS shim only. No partial/template/content/
SEO/analytics/config changes, and main.css is not recompiled here.

Known limitations (see PR): 28/35 service pages built & verified locally;
die-casting-tooling pages are not built in any language (unverified);
a pre-existing mobile overflow on de/cnc-machining (theme text-4xl) is NOT
addressed by this patch; production is not yet deployed.
diecasting added a commit that referenced this pull request Oct 14, 2026
…rids

Follow-up to 21cc47d (PR #9). Replaces gap-8 (absent from compiled
CSS bundle 1eb6d6, so a no-op) with gap-4 (present) on the two service
section grids that still used gap-8, completing the G1 grid repair
without depending on PR #7's CSS shim.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant