refactor(view): drop named-view sugar, converge to L13 flushState (task 2.14) - #52
Merged
Merged
Conversation
…sk 2.14) Strict-mode tighten of View\Factory to the L13 surface: - Remove named-view sugar removed in L13: `of()`, `name()`, `alias()`, `getNames()` + the `$names`/`$aliases` properties and the alias normalization in `make()`. Any surviving caller is now method-not-found (PHP+Psalm) — the forcing function for app conform. - Rename render-flush to L13 names: add `flushState()` (owns renderCount + delegates to flushSections), rename `flushSectionsIfDoneRendering()` -> `flushStateIfDoneRendering()`; `flushSections()` stays (sections-only, as in L13's ManagesLayouts). Update View::render() callers. - Keep `BladeCompiler::extend()` (not stripped pre-swap). Tests: drop the 3 obsolete Factory tests (named views / alias make); retarget View flush mocks to flushStateIfDoneRendering. tests/View green (121 tests, 193 assertions). App side (separate, in dicoding repo): 2 `Blade::extend` -> `Blade::directive()` is convergence, not forced (extend() kept). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Sep 15, 2026
Base automatically changed from
migration/2.7-config-getenvironment
to
pre-release/4.2.93
September 16, 2026 02:58
agissept
changed the base branch from
pre-release/4.2.93
to
pre-release/4.2.94
September 16, 2026 03:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 2.14 — View strict-mode tighten
[fork]Menyesuaikan
View\Factoryke surface L13 (strict-mode: idiom lama → method-not-found, memaksa app conform).Fork
of(),name(),alias(),getNames()+ properti$names/$aliases+ normalisasi alias dimake().flushState()(pegangrenderCount, delegasi keflushSections), renameflushSectionsIfDoneRendering()→flushStateIfDoneRendering().flushSections()tetap (sections-only, seperti traitManagesLayoutsL13). Update pemanggil diView::render().BladeCompiler::extend()(tidak di-strip pre-swap).Verifikasi
vendor/bin/phpunit tests/View/→ OK (121 tests, 193 assertions). PHP lint 4 file bersih. Nol sisa referensi method/properti yang dihapus di seluruhsrc/.Sisi app (terpisah, repo dicoding)
Blade::extend(2 callsite diDicodingServiceProvider) →Blade::directive()= konvergensi, tidak dipaksa (extend() dipertahankan). Dikerjakan lockstep di branchimprovement/l13-migration/view-conform.Urutan
Stacked di atas #48 (tip stack saat ini: #45←#46←#48←ini). Blocker (1.1 Contracts) sudah ✅.
🤖 Generated with Claude Code