Conversation
…task 0.2) Task 2.7 removed Config\Repository::getEnvironment() from the fork with no shim, so any surviving call is method-not-found (PHP+Psalm catches it). The grep-ratchet pattern is redundant with that type enforcement and, worse, false-positives on Queue\Listener::getEnvironment() — an unrelated worker method — keeping the count stuck at 1. Prune the pattern from the ratchet + baseline and move the row to a new "already type-enforced" section of the divergence ledger. First concrete slice of framework-first task 0.2 (demote ratchet to non-type patterns as components get type-tightened). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Dipindah/disatukan ke #48 (task 2.7): commit ratchet ini sekarang ada langsung di branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ringkas
Slice pertama task 0.2 (framework-first: demote ratchet CI ke pola non-type saat komponen sudah di-tighten).
Task 2.7 (parent PR #48) menghapus
Config\Repository::getEnvironment()dari fork tanpa shim → panggilan mana pun = method-not-found (PHP+Psalm menangkap). Pola grepconfig_getEnvironmentdi ratchet jadi:Queue\Listener::getEnvironment()(method worker, tak ada hubungannya dgn Config) → count mentok di 1 selamanya.Perubahan
ci/convergence-ratchet.sh: buang polaconfig_getEnvironment.ci/convergence-baseline.txt: buang barisconfig_getEnvironment=3.docs/DIVERGENCE-LEDGER.md: pindah baris ke seksi baru "Sudah type-enforced (dipindah dari ratchet)".Verifikasi
ci/convergence-ratchet.sh src→ exit 0, pola sudah tak muncul, tak ada false-positive lagi.Catatan urutan
Stacked di atas #48 (task 2.7) karena valid hanya setelah
getEnvironment()benar-benar hilang dari fork. Jangan merge kedev-13mendahului #48.🤖 Generated with Claude Code