Address post-merge review feedback for recipe E2E coverage - #1278
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
There was a problem hiding this comment.
🟡 Changes recommended
There are a few correctness/contract issues (TypeScript narrowing in E2E specs, MSW restore response shape completeness, and missing 401 OpenAPI documentation for the new status endpoint) that should be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR follows up on #1277 by strengthening recipe delete/restore coverage in Storybook and making Playwright E2E runs safer when reusing an existing Aspire stack by verifying cleanup support up-front.
Changes:
- Extends the RecipeDetail Storybook story to cover the delete “Undo” (restore) flow, including MSW wiring and an interaction assertion.
- Adds a
/statusendpoint to the E2E cleanup API and introduces a Playwright helper + per-spec preflight check to fail early on stale/reused Aspire stacks. - Registers Quasar
Notifyin Storybook preview so notification-driven interactions can be asserted.
File summaries
| File | Description |
|---|---|
| ui/menu-website/src/pages/RecipeDetail.stories.ts | Adds restore handler usage + interaction assertions for delete/Undo notifications. |
| ui/menu-website/e2e/test-helpers.ts | Adds cleanup status preflight helper and centralizes cleanup base URL usage. |
| ui/menu-website/e2e/recipe-detail.spec.ts | Adds cleanup-availability preflight before seeding/creating data. |
| ui/menu-website/e2e/edit-delete-recipe.spec.ts | Adds cleanup-availability preflight before creating fixtures. |
| ui/menu-website/e2e/create-recipe.spec.ts | Adds cleanup-availability preflight before creating fixtures. |
| ui/menu-website/.storybook/preview.ts | Registers Quasar Notify plugin for Storybook runtime parity. |
| ui/menu-website/.storybook/msw-handlers.ts | Adds MSW restore handler for the delete/Undo Storybook scenario. |
| backend/MenuApi/Recipes/E2eTestCleanupApi.cs | Adds /status endpoint for E2E cleanup capability checks. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|



Summary
Follow-up to merged PR #1277, incorporating the remaining review feedback about Storybook coverage and reused Aspire stacks.
Related to #1277
Changes
Verification
dotnet build MenuApi.sln --configuration Release --no-restore— passed with 0 warnings and 0 errors.pnpm build— passed.pnpm lint— passed with 0 errors and 16 existing warnings.spawn EPERM; no Storybook assertion result is claimed locally.