Skip to content

Deal with SLF4J transitive dependency #99

Description

@andrus

Currently, eu.maveniverse.maven.mima.runtime:standalone-static:

  1. brings in a transitive dependency on org.slf4j:jcl-over-slf4j:jar:1.7.36 to plug in place of commons-logging used by some Maven libs.
  2. Uses SLF4J Logger by itself

So while we are shading the dependency, it still causes havoc in Jupyter on kernel startup:

Running JJava Kernel with args: [java, -Xmx20480m, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens, jdk.jshell/jdk.jshell=ALL-UNNAMED, -jar, /Users/andrus/Library/Jupyter/kernels/java/jjava.jar, /Users/andrus/Library/Jupyter/runtime/kernel-fcc06d79-0257-40b4-9c55-81df889384cc.json]
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

I suppose the solution is to keep the SLF bridge and add slf4j-jdk14 to route it to JUL (both shaded)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions