Skip to content

fix: handler가 없을때 트랜잭션 deleteElastic이 호출되지 않는 버그 수정 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devxb merged 1 commit into from
Feb 15, 2024
Merged

fix: handler가 없을때 트랜잭션 deleteElastic이 호출되지 않는 버그 수정 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/kotlin/org/rooftop/netx/engine/AbstractTransactionDispatcher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ abstract class AbstractTransactionDispatcher {

fun dispatch(transaction: Transaction, messageId: String): Flux<Any> {
return Mono.just(transaction.state)
.doOnNext { deleteElastic(transaction, messageId) }
.filter { state -> transactionHandlerFunctions.containsKey(state) }
.flatMapMany { state ->
Flux.fromIterable(
Expand All @@ -26,7 +27,6 @@ abstract class AbstractTransactionDispatcher {
}
.flatMap { (function, instance) ->
mapToTransactionEvent(transaction)
.doOnNext { beforeInvokeHook(transaction, messageId) }
.flatMap { function.call(instance, it) }
}
.doOnComplete {
Expand Down Expand Up @@ -84,7 +84,7 @@ abstract class AbstractTransactionDispatcher {
messageId: String
): Mono<Pair<Transaction, String>>

protected abstract fun beforeInvokeHook(
protected abstract fun deleteElastic(
transaction: Transaction,
messageId: String
)
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/org/rooftop/netx/redis/RedisStreamTransactionDispatcher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class RedisStreamTransactionDispatcher(
)
}

override fun beforeInvokeHook(
override fun deleteElastic(
transaction: Transaction,
messageId: String
) = redisStreamTransactionRemover.deleteElastic(transaction)
Expand Down
2 changes: 1 addition & 1 deletion src/test/kotlin/org/rooftop/netx/redis/NoAckRedisStreamTransactionDispatcher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class NoAckRedisStreamTransactionDispatcher(
override fun ack(transaction: Transaction, messageId: String): Mono<Pair<Transaction, String>> =
Mono.just(transaction to messageId)

override fun beforeInvokeHook(
override fun deleteElastic(
transaction: Transaction,
messageId: String
) {
Expand Down