Repository navigation
Conversation
JavaFactories::createOwning() keeps the reference in its smart pointer until the wrapper exists and its handle is bound, so a failed creation no longer leaks the native object.
Owner
Author
|
Superseded by #516, which landed the same fix on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call sites gave up their native reference (
JavaFactories::create(env, x.release())) before the Java wrapper existed, so a failed wrapper creation leaked the native object.JavaFactories::createOwning(), which keeps the reference in its smart pointer until the wrapper is created and its handle bound, and use it at all such call sites.createPeerConnectionInternalnow owns its observer in aunique_ptrand catches C++ exceptions.createOwningObjectArrayhands over references only once every element exists.JavaFactory::create()owns the new local reference right away.