Repository navigation
fix: report certificate expiration and fail library load on init errors - #513
Merged
Merged
Conversation
Native certificates carry their expiration time in milliseconds, or RTCCertificatePEM.EXPIRES_UNKNOWN, passed as a jlong. JNI_OnLoad keeps the context local until it is initialized, cleans it up on failure and returns JNI_ERR; the VM is set apart from the context for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTCCertificatePEM.getExpires()of native certificates (remote certificates ofRTCDtlsTransport,getConfiguration()) was always 0. It now carries the certificate's expiration time in milliseconds, or the newEXPIRES_UNKNOWN(-1) if it cannot be read, passed to the constructor as ajlonginstead of anintliteral.JNI_OnLoadlets no C++ exception escape, keeps the context local until it is fully initialized, cleans it up on failure and returnsJNI_ERR, so the load fails with the translated exception. The JavaVM is now set apart from the context, since initializing it already needs the VM.