#2278: Split main-view.fxml into separate layout components - #2297
Open
krystynaShatkovska wants to merge 7 commits into
Open
#2278: Split main-view.fxml into separate layout components#2297krystynaShatkovska wants to merge 7 commits into
krystynaShatkovska wants to merge 7 commits into
Conversation
- Remove setController() to avoid conflict with fx:controller in FXML - Add initialized flag to MainController.initialize() to run only once across all 3 FXML files (main-view, navigation, status-bar) - All 56 GUI tests pass Co-Authored-By: Capgemini Sovereign AI Platform
Collaborator
Coverage Report for CI Build 31468725246Coverage increased (+0.007%) to 72.888%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions34 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
laim2003
approved these changes
Aug 10, 2026
Contributor
There was a problem hiding this comment.
Thanks for your PR! Looks good! Sadly I hoped that JavaFX allows for an easier way to fragment layouts without having to add extra checks, but it seems like JavaFX is not very flexible. From what I could research, using a controller factory seems to be the most common way to implement this. Maybe we should rethink the way we will fragment the UI in the future. For now this is good in my opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2278
Implemented changes:
Split main-view.fxml (~300 lines) into three FXML files using fx:include tags:
Controller integration:
All fx:id references and onAction handlers preserved and verified.
Testing instructions
Build the project with mvn clean test and verify all tests pass
Launch the IDEasy GUI and confirm the main window renders correctly with all three regions (sidebar, center IDE rows, bottom status bar)
Interact with each region to verify functionality is unchanged:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
with internal