Skip to content

ci: run perf and website deploy when packages/core changes - #210

Merged
devlint merged 4 commits into
devlint:mainfrom
MarkAlex1234:ci/watch-packages-core
Oct 6, 2026
Merged

devlint merged 4 commits into
devlint:mainfrom
MarkAlex1234:ci/watch-packages-core

Conversation

@MarkAlex1234

Copy link
Copy Markdown
Contributor

Commit 1 (the fix). Two workflows depend on @gitwand/core but don't watch packages/core/**:

  • perf.yml explicitly runs pnpm --filter @gitwand/core run build before the desktop parity probe, and apps/desktop depends on @gitwand/core (workspace:*). But it only triggers on apps/desktop/**, so a resolver change in core, the thing most likely to move performance, never runs the perf check.
  • deploy-website.yml: the website depends on @gitwand/core (workspace:*) and imports it in .vitepress/config.ts and theme/tools/index.ts. A core change merged to main doesn't redeploy the site until something under website/ changes.

This adds packages/core/** to perf.yml (push and pull_request) and to deploy-website.yml (push). Three lines.

Commit 2 (optional). This adds .github/workflows/path-filter-audit.yml, a small pull_request job that warns when a workflow's paths: stops covering the workspace packages its app depends on. It keeps these lists from drifting again. It only annotates and never fails the build; drop the commit if you'd rather not add a workflow.

On main today it reports exactly these three gaps, for example: "packages/core/** is missing from on.pull_request.paths: @gitwand/desktop depends on @gitwand/core, so a change there skips this workflow." With commit 1 applied, it reports none.

Disclosure: the audit is a GitHub Action I maintain, dynamic-monorepo.

Verification: all workflow YAML parses, and I ran the audit locally (npx github:Continuous-Actions/dynamic-monorepo audit) before and after: 3 findings, then 0.

MarkAlex1234 and others added 4 commits October 5, 2026 23:08
perf.yml builds @gitwand/core before the desktop parity probe and the website depends on @gitwand/core (workspace:*), but neither workflow triggered on packages/core/**.
Warns on PRs when a workflow's on.paths list no longer covers the workspace packages it builds. Warning only; never fails the build.

@devlint devlint left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — the path additions are right: perf.yml already builds @gitwand/core before the parity probe, and the website imports it.

I pushed two commits to this branch: a revert of the path-filter-audit workflow (we keep third-party actions out of CI, and @v1 is a mutable ref), and a one-line update of the comment at the top of perf.yml so it mentions packages/core/. Both workflow files parse; the remaining diff is the original three-line fix.

@devlint
devlint merged commit 7b1af40 into devlint:main Oct 6, 2026
@devlint

devlint commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Thanks @MarkAlex1234 — good catch on the path filters: core changes now run the perf check and redeploy the site. We kept the three-line fix and left the audit workflow out (we avoid third-party actions in CI), as noted in the review. Shipped with v3.12.0, released today. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants