Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
devhims
force-pushed
the
fix/numerical-grounding-only
branch
from
October 7, 2026 11:55
404c0f2 to
d62d241
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Users can wait through redundant context preparation after research has already collected the needed analyses. Supported answers can also be rejected because optional identity metadata differs across videos. Missing rejected drafts make those failures difficult to diagnose.
What changed
Research now ends with a report of request parts, supporting evidence references and unresolved questions. With a valid report, finalization skips the general preparation model loop. Application checks identify missing subjects, invalid references, stale evidence and coverage limitations. At most four targeted saved-asset or history reads address identified gaps. Repair reuses those reads.
Private agent traces retain the handoff decision, targeted reads and rejected answers, including detailed validation errors and the responding model. Existing access and deletion controls apply.
Grounding rejection focuses on numerical support. Optional names are advisory; measurements, citations and answer structure retain their checks.
%%{init: {"themeVariables": {"signalColor": "#64748b", "sequenceNumberColor": "#ffffff"}}}%% sequenceDiagram autonumber participant R as Research participant P as Preparation model participant A as Application participant F as Answer model rect rgba(128,128,128,0.08) Note over R,F: Before R->>P: Collected evidence P->>A: General context reads A->>F: Generate answer end rect rgba(128,128,128,0.08) Note over R,F: After a valid handoff R->>A: Findings and explicit gaps A->>A: Validate coverage and perform targeted reads A->>F: Generate answer endThe preparation model loop is removed for valid research handoffs; application checks and answer generation remain.
Tests
All 1,560 unit tests and 347 runtime/session integration tests pass. Type checking passes. Tests cover four available analyses, explicit and missing-subject reads, repair reuse, cancellation, billing admission, time/cost reserves, cross-video names and rejection traces.
Compatibility and deployment
No migration is required. History/context requests and research without a valid report retain existing preparation. Recovery does not restore reports from traces. Semantic completeness still requires model judgment. Platform deployment and live latency verification remain outstanding.