Repository navigation
added the markup and part-logic for the number base converter - #38
Closed
tobySolutions wants to merge 1 commit into
Closed
tobySolutions wants to merge 1 commit into
tobySolutions wants to merge 1 commit into
Conversation
❌ Deploy Preview for developertools-tech failed.
|
Member
|
@tobySolutions This can't be merged as is, I'm sorry for that, but this code is failing all tests. Is there anything I can do to help you with this? |
Author
|
Oh! I forgot to actually write tests for the feature I added.
Regardless, I didn't actually complete the feature, I just gave it a cool
markup.
…On Fri, 7 Oct 2022, 4:46 pm DL Ford, ***@***.***> wrote:
@tobySolutions <https://github.com/tobySolutions> This can't be merged as
is, I'm sorry for that, but this code is failing all tests. Is there
anything I can do to help you with this?
—
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW67EG67R5GFBMZVRG2I523WCBAWLANCNFSM6AAAAAAQ7KIOFQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@tobySolutions @nobalpha is going to take this over and use your existing work if able to, thanks for the part you played in it! |
Author
|
My pleasure!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Pull Request
Related Issue #s or links (if any):
Description of Changes
I was able to build the markup for the number base converter and I added a bit of logic to the conversion. Sadly I couldn't't do more than that. I hope this gets merged and someone else continues from there.