Repository navigation
CSS Format/Minify Tool - #29
Merged
Merged
Conversation
dlford
requested changes
Oct 5, 2022
dlford
left a comment
dlford
left a comment
Member
There was a problem hiding this comment.
@nosecreek Great job on this! I just have a couple notes if it's not too much trouble.
| expect(formattedCss.innerHTML).toContain('background: #ffffff;'); | ||
| expect(formattedCss.innerHTML).toContain('\n'); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
Can we also test that minify works correctly?
| css, | ||
| 'body{background:#ffffff;}'.replace(/[{[]/g, '$&$&'), | ||
| ); | ||
| expect(formattedCss.innerHTML).toContain('body {'); |
Member
There was a problem hiding this comment.
I'd rather see us match exact output here, like the JSON tests.
Contributor
Author
|
I think those are both great suggestions. Should be fixed by the latest commit. |
Member
|
@nosecreek Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Pull Request
Related Issue #s or links (if any):
#14
Description of Changes
Added a CSS page which includes a formatter and minifier.
Note: minification is not currently available for SCSS/LESS. SCSS cannot currently be run in the browser (see sass/dart-sass#25).