Skip to content

HTML Format - #18

Merged
dlford merged 4 commits into
developertools-tech:devfrom
mvarrieur:main
Oct 4, 2022
Merged

dlford merged 4 commits into
developertools-tech:devfrom
mvarrieur:main

Conversation

@mvarrieur

@mvarrieur mvarrieur commented Oct 4, 2022 •

Copy link
Copy Markdown
Contributor

Type of Pull Request

  • Bug fix
  • Enhancement

Related Issue #s or links (if any): #8

Description of Changes

  • Add HTML Formatter via Prettier

Note: I tried finding a minifier that would work in the browser but didn't have luck, the few I tried required node

@netlify

netlify Bot commented Oct 4, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for developertools-tech ready!

Name Link
🔨 Latest commit f24d47d
🔍 Latest deploy log https://app.netlify.com/sites/developertools-tech/deploys/633cacef08318c0009c9633d
😎 Deploy Preview https://deploy-preview-18--developertools-tech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mvarrieur
mvarrieur changed the base branch from main to dev October 4, 2022 01:15
@dlford dlford linked an issue Oct 4, 2022 that may be closed by this pull request
@dlford

dlford commented Oct 4, 2022

Copy link
Copy Markdown
Member

@mvarrieur Looks like there is a TypeScript compiler error:

ksnip_20221003-190218

@dlford dlford mentioned this pull request Oct 4, 2022
@dlford dlford removed a link to an issue Oct 4, 2022
@mvarrieur

Copy link
Copy Markdown
Contributor Author

@dlford Thanks, fixed that and resolved merge conflicts.

@dlford dlford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvarrieur great job on this! Can we add an error message like the JSON tool so it's clear what is wrong with the input when there is an error?

@mvarrieur

Copy link
Copy Markdown
Contributor Author

I can take a look at what prettier prov

@mvarrieur great job on this! Can we add an error message like the JSON tool so it's clear what is wrong with the input when there is an error?

I can take a look at what prettier provides in the error that gets thrown later tonight or tomorrow, but I'm not quite sure what level of detail is there

@dlford

dlford commented Oct 4, 2022

Copy link
Copy Markdown
Member

I can take a look at what prettier prov

@mvarrieur great job on this! Can we add an error message like the JSON tool so it's clear what is wrong with the input when there is an error?

I can take a look at what prettier provides in the error that gets thrown later tonight or tomorrow, but I'm not quite sure what level of detail is there

Thank you! It doesn't have to be super specific, as long as it gives some idea as to what the problem is.

@mvarrieur

Copy link
Copy Markdown
Contributor Author

@dlford Added error output from prettier to the page
Screenshot 2022-10-04 at 17-47-24 DeveloperTools Tech

@mvarrieur

mvarrieur commented Oct 4, 2022 •

Copy link
Copy Markdown
Contributor Author

Sorry not sure why I'm not seeing the TS errors on my side until I push, taking a look now. Fixed

@dlford

dlford commented Oct 4, 2022

Copy link
Copy Markdown
Member

@mvarrieur Perfect, I like that you put the error message above the output field, I might do that for JSON to. Thank you!

@dlford dlford added the hacktoberfest-accepted This PR will be counted for Hacktoberfest label Oct 4, 2022
@dlford
dlford merged commit 5d067c5 into developertools-tech:dev Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted This PR will be counted for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants