Skip to content

[Bug]: Aspect ratio preview odd behavior #1

New issue
New issue
Open
Open
[Bug]: Aspect ratio preview odd behavior#1
Labels
bugSomething isn't workinggood first issueGood for newcomershacktoberfestThis is a valid Hacktoberfest issuehelp wantedAnyone can pick this up and start working on it

Description

@dlford
dlford
opened on Sep 11, 2022

Contact Details

No response

What happened?

Choosing an extremely low width or height causes the preview window to show an inaccurate representation of that aspect ratio

What should have happened?

Aspect ratio preview should show an accurate representation of the selected ratio

What browsers are you seeing the problem on?

Firefox

Version

104.0.2

Relevant Code

https://github.com/developertools-tech/developertools.tech/blob/main/components/aspectRatio/Preview.tsx#L15

Activity

  1. dlford
    added
    bugSomething isn't working
    tool: aspect ratio
    triageNew issue that needs to be assessed
    approved
    help wantedAnyone can pick this up and start working on it
    good first issueGood for newcomers
    and removed
    triageNew issue that needs to be assessed
    tool: aspect ratio
    approved
    on Sep 11, 2022
  2. dlford
    added
    hacktoberfestThis is a valid Hacktoberfest issue
    on Oct 3, 2022

  3. nobalpha commented on Oct 8, 2022

    @nobalpha
    nobalpha
    on Oct 8, 2022

    Hey @dlford , can I try to resolve it?

  4. dlford
    assigned
    nobalpha
    on Oct 8, 2022
  5. dlford
    removed
    help wantedAnyone can pick this up and start working on it
    on Oct 8, 2022

  6. dlford commented on Oct 8, 2022

    @dlford
    dlford
    on Oct 8, 2022
    MemberAuthor

    @nobalpha All yours, thanks!

  7. dlford
    added a commit that references this issue on Oct 9, 2022

    Merge pull request #1 from dlford/text-diff

    005f79b

  8. dlford commented on Oct 19, 2022

    @dlford
    dlford
    on Oct 19, 2022
    MemberAuthor

    @nobalpha are you still wanting to work on this?

  9. nobalpha commented on Oct 20, 2022

    @nobalpha
    nobalpha
    on Oct 20, 2022

    @dlford So sorry to reply lately... Can you please accord a little bit more time?

  10. dlford commented on Oct 20, 2022

    @dlford
    dlford
    on Oct 20, 2022
    MemberAuthor

    @nobalpha no problem, just making sure you still wanted to do it!

  11. dlford
    removed
    hacktoberfestThis is a valid Hacktoberfest issue
    on Nov 6, 2022

  12. dlford commented on Dec 18, 2022

    @dlford
    dlford
    on Dec 18, 2022
    MemberAuthor

    Hey @nobalpha, are you still working on this?

  13. dlford
    unassigned
    nobalpha
    on Jan 12, 2023
  14. dlford
    added
    help wantedAnyone can pick this up and start working on it
    on Jan 12, 2023
  15. dlford
    added
    hacktoberfestThis is a valid Hacktoberfest issue
    on Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershacktoberfestThis is a valid Hacktoberfest issuehelp wantedAnyone can pick this up and start working on it

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions