downcase OCI identifiers and validate input of getRef() - #293
Merged
Conversation
joshspicer
marked this pull request as ready for review
November 22, 2022 22:04
Samruddhi Khandale (samruddhikhandale)
previously approved these changes
Nov 22, 2022
Christof Marti (chrmarti)
requested changes
Nov 23, 2022
joshspicer
requested review from
Christof Marti (chrmarti) and
Samruddhi Khandale (samruddhikhandale)
November 23, 2022 15:48
joshspicer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downcases the identifier input string (context: oras-project/oras#679)
Additionally, be more strict about what the Feature/Template OCI identifiers that we parse.
getRef()now returnedundefinedif the parsed components don't match the regular expressions provided in the OCI distribution spec.Adds new tests to assert this behavior.
NOTE: This isn't perfect yet, but an improvement. Left two
TODOs inline.relevant: