Skip to content

fix(feedback): generate valid automatic retry keys - #12

Open
Simon Liang (AgentWings) wants to merge 1 commit into
dedalus-labs:stainless-nextfrom
AgentWings:fix/pla-174-feedback-retry-keys
Open

Simon Liang (AgentWings) wants to merge 1 commit into
dedalus-labs:stainless-nextfrom
AgentWings:fix/pla-174-feedback-retry-keys

Conversation

@AgentWings

@AgentWings Simon Liang (AgentWings) commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Generate 32-character UUIDv7 idempotency keys for synchronous and asynchronous requests. The previous prefixed UUIDv4 values fail feedback's public header contract.

Changes

  • Generate the API's UUIDv7 key format without a new runtime dependency.
  • Test the real request builder: a 503 automatic retry keeps its key and a new submission gets a different key.
  • Document automatic retry identity.

Verification

  • Before the fix, the new request-builder tests failed on the prefixed UUIDv4 header.
  • .venv/bin/python -m pytest tests/test_feedback_retry.py tests/test_client.py -q -n 0 --tb=short: 149 passed, 2 existing skips. Ruff passed on the changed Python files.
  • git diff --check passed.

Readiness

  • Reviewed the final diff and captured red-to-green evidence.
  • Verified automatic retry identity and independent submission identity.
  • Hosted checks and reviewer approval.

Evidence

Before: The outgoing default key did not match ^[0-9a-f]{12}7[0-9a-f]{3}[89ab][0-9a-f]{15}$.

After: The real request builder emits a matching key, preserves it over an automatic 503 retry, and generates a new key for a new submission. Transport fixtures exercise the client without contacting a live API.

Scope

Review surface Size or relationship
Human-written diff 67 changed LOC
Target <200 LOC
Hard maximum 500 LOC
Generated diff 0 changed LOC
Stack Standalone runtime fix.

Review focus

  • This changes the default key format for all SDK writes. Explicit caller-supplied keys and retry boundaries stay supported.
  • This PR remains a draft. Integration with the next SDK release and package verification remain pending.

Documentation

Repro / Showcase

N/A (no visual surface changed).

Reviewers

Signed-off-by: Shengming Liang <231182611+AgentWings@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant