Repository navigation
fix(feedback): generate valid automatic retry keys - #12
Open
Simon Liang (AgentWings) wants to merge 1 commit into
Open
Simon Liang (AgentWings) wants to merge 1 commit into
Simon Liang (AgentWings) wants to merge 1 commit into
Conversation
Signed-off-by: Shengming Liang <231182611+AgentWings@users.noreply.github.com>
Simon Liang (AgentWings)
marked this pull request as ready for review
September 15, 2026 20:52
Simon Liang (AgentWings)
requested a review
from Windsor Nguyễn (windsornguyen)
as a code owner
September 15, 2026 20:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate 32-character UUIDv7 idempotency keys for synchronous and asynchronous requests. The previous prefixed UUIDv4 values fail feedback's public header contract.
Changes
Verification
.venv/bin/python -m pytest tests/test_feedback_retry.py tests/test_client.py -q -n 0 --tb=short: 149 passed, 2 existing skips. Ruff passed on the changed Python files.git diff --checkpassed.Readiness
Evidence
Before: The outgoing default key did not match
^[0-9a-f]{12}7[0-9a-f]{3}[89ab][0-9a-f]{15}$.After: The real request builder emits a matching key, preserves it over an automatic 503 retry, and generates a new key for a new submission. Transport fixtures exercise the client without contacting a live API.
Scope
Review focus
Documentation
Repro / Showcase
N/A (no visual surface changed).
Reviewers