Repository navigation
Robust error handling when interacting with API #22
Description
The current REST interactions with the API frequently swallow errors and throw up NullPointerExceptions without much warning.
A more robust error handling system is in order. It should give the user the option to check for errors wherever the library sends a request. This may require rather large breaking changes.
Take DestinyAPI.getMemberFromSteamID
We want to wrap the return with some sort of container which can be checked.
public static Response<BungieUser> getMemberFromSteamID(String steamID) {
return getMemberFromPlatformID("SteamId", steamID);
}Then when handling the result we should be able to use functions like
response.isOkay() // if the request completed ok
response.isError() // api returned an error
response.getErrorMessage() // return error message from api
response.inner() // returns the BungieUser object
response.isApiOnline() // is the api online? or was it another error
response.inherit(new object) // pass error messages and such with a new object, like converting jsonobject to BungieUserMetadata
Metadata
Assignees
Labels
No labels
Activity
#22 - Add BungieResponse, additional fixes and new exception structure
#22 - Progress towards response structure, update copyright
#22 - Convert more stuff
#22 - Convert more stuff
#22 - Added documentation, more work
#22 - Final for this attempt
#22 - Throw APIException
#22 - Add more error catching
#22 - Don't refresh every time, documentation
#22 - Update copyright and dependencies
#22 - Update README and other docs