Repository navigation
fix(budget): show "Saving..." on form submit buttons during pending mutations - #272
Merged
Merged
Conversation
…utations Aligns budget form submit buttons with the established loading-feedback pattern used in vendor-form and wedding-settings-form. Expense, category, and budget-settings dialogs now display "Saving..." while the mutation is in flight instead of leaving the button label unchanged.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Jest Test CoverageCoverage Summary
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Budget form submit buttons were not providing visual feedback while mutations were in flight. This PR aligns three budget forms with the established pattern already used in
vendor-form.tsxandwedding-settings-form.tsx.Changed files
src/components/budget/expense-form.tsx— submit button now shows"Saving..."while the create/update mutation is pendingsrc/components/budget/category-form.tsx— submit button now shows"Saving..."while the create/update mutation is pendingsrc/components/budget/budget-summary.tsx— budget settings dialog submit button now shows"Saving..."while the update mutation is pendingBefore / After
Before — button stays labelled
"Add expense"/"Save changes"/"Save"even while disabled during the network call.After — button reads
"Saving..."whenever the underlying tRPC mutation isisPending, matching the pattern invendor-form.tsx:Daily improvement report
Selected improvement
Add "Saving…" loading text to budget form submit buttons — small UX consistency fix, no new dependencies, 3-line change, all 2035 unit tests pass.
Other recommendations reviewed (not implemented here)
task-dialog.tsxsubmit buttonupcoming-payments.tsx— use explicit locale intoLocaleDateString()startTimeis set (noendTime)category-card.tsxGenerated by Claude Code