Repository navigation
Conversation
…ned half-width layout On medium (tablet) screens the three-card bottom row used md:grid-cols-2, leaving MilestonesCard alone at half-width in a new row with blank space beside it. Wrap it in a div with md:col-span-2 lg:col-span-1 so it fills the row at md and returns to one-third width at lg.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily Product Improvement
Summary
On medium (tablet) screens, the three-card bottom row of the dashboard uses
md:grid-cols-2, which placesBudgetCardandVendorsCardin a first row and leavesMilestonesCardalone at half-width in a second row with blank space beside it. This fix wrapsMilestonesCardin adivwithmd:col-span-2 lg:col-span-1so it fills the full row at the md breakpoint and returns to one-third width at lg.Recommendations Reviewed
Area:
src/components/dashboard/planning-overview.tsxIssue: On md (768px–1024px) screens, the 3-card bottom row uses
md:grid-cols-2. With 3 cards, CSS Grid places BudgetCard + VendorsCard in row 1 and MilestonesCard alone at 50% width in row 2, leaving a blank half-column.Recommendation: Wrap MilestonesCard in a
divwithmd:col-span-2 lg:col-span-1.Type: UX/UI
Priority: Medium
Effort: Small
Area:
src/components/dashboard/planning-overview.tsxIssue: The
MiniStats4-stat grid usesgrid-cols-2 lg:grid-cols-4, showing as a 2×2 grid on md/tablet screens instead of a single row.Recommendation: Add
md:grid-cols-4to show all 4 stats in one row from tablet onwards. Note: the "Tasks due this month" label may wrap at narrower tile widths — evaluate before applying.Type: UX/UI
Priority: Low
Effort: Small
Area:
src/components/dashboard/planning-overview.tsxIssue: All 7 dashboard card components (CountdownHero, MiniStats, RsvpCard, TasksCard, BudgetCard, VendorsCard, MilestonesCard) are defined in a single 646-line file, making it harder to navigate and maintain.
Recommendation: Extract each card into its own file under
src/components/dashboard/cards/.Type: Frontend cleanup
Priority: Medium
Effort: Large
Area:
src/components/guest-list/v2/list/guest-individual-table.tsxIssue: The Contact Complete and Location Complete columns display "Complete" or "Missing" as text, requiring more horizontal space and slower visual scanning than icon-based indicators.
Recommendation: Replace with CheckCircle/XCircle icons (lucide-react) to reduce column width and improve scanability.
Type: UX/UI
Priority: Low
Effort: Small
Area:
src/app/(authenicated)/guest-list/page.tsxIssue: The page's exported server component is named
DashboardPageinstead ofGuestListPage— a copy-paste naming error that is confusing when navigating the codebase.Recommendation: Rename to
GuestListPage.Type: Frontend cleanup
Priority: Low
Effort: Small
Area:
src/components/dashboard/planning-overview.tsx—MilestonesCardIssue: The wedding-day marker uses a raw
✦Unicode character and the override warning uses⚠, both inline in JSX text. These are inconsistent with the Lucide icon system used elsewhere.Recommendation: Replace
⚠withAlertTrianglefrom lucide-react; leave✦as decorative (it fits the serif aesthetic).Type: UX/UI
Priority: Low
Effort: Small
Selected Improvement
Fix
MilestonesCardlayout at the md breakpoint: wrap it in<div className='md:col-span-2 lg:col-span-1'>so it spans the full row on tablet screens instead of rendering at half-width with blank space beside it.Why This Was Selected
The dashboard is the first thing users see every session. On tablets and mid-size browser windows (768px–1024px), the current layout produces a visually incomplete row — MilestonesCard at 50% width with an empty half-column next to it. This is the most user-visible layout issue not already covered by an open PR, and the fix is a single wrapper div with two Tailwind classes.
Changes Made
<MilestonesCard>in<div className='md:col-span-2 lg:col-span-1'>inside the bottom grid row.Files Changed
src/components/dashboard/planning-overview.tsxVerification
tsc --noEmit): passed with no errors (one pre-existing deprecation warning aboutbaseUrlunrelated to this change).Future Recommendations
Recommendation: Extract each dashboard card (CountdownHero, MiniStats, RsvpCard, TasksCard, BudgetCard, VendorsCard, MilestonesCard) into separate files under
src/components/dashboard/cards/Priority: Medium
Effort: Large
Reason not included: Splitting a 646-line file into 7+ files is a Large refactor with broad diff scope — not appropriate for a single daily run.
Should become GitHub issue: Yes
Recommendation: Add
md:grid-cols-4toMiniStatsso the 4 stat tiles appear in a single row on tabletsPriority: Low
Effort: Small
Reason not included: The "Tasks due this month" label is likely to wrap at ~184px tile width on md. Requires a label shortening or truncation decision before applying.
Should become GitHub issue: No
Recommendation: Replace "Complete"/"Missing" text in the guest individual table with CheckCircle/XCircle icons
Priority: Low
Effort: Small
Reason not included: Low priority and narrower user impact (Person Audit view only); the dashboard layout fix is higher value today.
Should become GitHub issue: No
Recommendation: Rename
DashboardPageexport inguest-list/page.tsxtoGuestListPagePriority: Low
Effort: Small
Reason not included: Pure naming cleanup; not user-facing.
Should become GitHub issue: No
Recommendation: Replace inline
⚠with a LucideAlertTriangleicon inMilestonesCardPriority: Low
Effort: Small
Reason not included: Minor polish; the emoji is functional and not blocking anything.
Should become GitHub issue: No
GitHub Issues Created or Proposed
No GitHub issues created. The largest item (splitting
planning-overview.tsx) is worth tracking, but the codebase already has many open PRs from prior daily runs and creating a separate issue today risks adding noise without immediate value. Recommend the repo maintainer evaluate the file size issue in context of existing PR backlog before opening a dedicated issue.Generated by Claude Code