Repository navigation
Conversation
…archy Subsection headings (Plugins, Organization Members, Connected Apps) were using text-xl — the same size as the parent h2 (Wedding Details) — making the page read as a flat list rather than a structured hierarchy. Reducing them to text-lg gives the page a clear two-level visual hierarchy so users can scan and orient quickly.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily Product Improvement
Summary
Reduced the three h3 subsection headings on the Settings page ("Plugins", "Organization Members", "Connected Apps") from
text-xltotext-lg. Previously they shared the same visual size as the h2 "Wedding Details" heading, producing a flat, hard-to-scan layout. Now the page has a clear two-level hierarchy.Recommendations Reviewed
Area:
src/app/(authenicated)/settings/page.tsxIssue: h2 "Wedding Details" and all three h3 subsections ("Plugins", "Organization Members", "Connected Apps") use
text-xl, giving every heading the same visual weight. The page reads as a flat list rather than a structured hierarchy.Recommendation: Reduce h3 elements to
text-lgso the top-level heading is visually dominant and subsections are clearly subordinate.Type: UX/UI · Priority: Medium · Effort: Small
Area:
src/components/dashboard/planning-overview.tsxIssue: Both
MiniStatsandRsvpCardcontain nearly identicalreduce()calls to compute RSVP totals from events data, duplicating business logic in the same file.Recommendation: Extract a shared
calculateRsvpSummary()helper to eliminate the duplication.Type: Frontend cleanup · Priority: Medium · Effort: Small
Area:
src/components/dashboard/dashboard-topbar.tsxIssue:
todaystate initialises as''and gets set inuseEffect, briefly rendering an empty string where the date label appears on desktop.Recommendation: Add a stable minimum-width placeholder so there is no layout shift before the date populates.
Type: UX · Priority: Low · Effort: Small
Area:
src/components/guest-list/guest-search-filter.tsxIssue: Three filter dropdowns use custom
useOuterClick-based show/hide state and olderreact-iconslibraries instead of the app-standard Radix UI components, creating keyboard/accessibility gaps and visual inconsistency.Recommendation: Replace with shadcn/ui
PopoverorDropdownMenucomponents.Type: Frontend cleanup · Priority: Medium · Effort: Large
Area: Multiple large component files (
guests-view.tsx~999 lines,vendor-detail-panel.tsx~936 lines,organization-members-settings-card.tsx~884 lines)Issue: These files have grown very large and are hard to navigate and review.
Recommendation: Decompose into smaller focused sub-components.
Type: Frontend cleanup · Priority: Medium · Effort: Large
Area:
tsconfig.jsonIssue: After the path-alias normalisation commit (f54d104), the old
@/*alias still exists in tsconfig as dead config alongside~/*.Recommendation: Remove the
@/*path entry from tsconfig.json to keep configuration clean.Type: Frontend cleanup · Priority: Low · Effort: Small
Selected Improvement
Reduce h3 subsection headings on the Settings page from
text-xltotext-lg.Why This Was Selected
The settings page is visited by every user who wants to update names, toggle plugins, manage collaborators, or connect apps. The flat heading hierarchy — where h3 subsections visually weigh the same as the top-level h2 — makes the page harder to scan quickly. The fix is a single-file, zero-risk change with immediate UX benefit. No open PR overlaps with it (PR #235 touches
settings/loading.tsx; PR #224 toucheswedding-settings-form.tsx).Changes Made
h3class fromfont-serif text-foreground text-xltofont-serif text-foreground text-lgfor "Plugins", "Organization Members", and "Connected Apps" insrc/app/(authenicated)/settings/page.tsx.Files Changed
src/app/(authenicated)/settings/page.tsxVerification
Future Recommendations
RSVP summary calculation duplication in planning-overview.tsx
Priority: Medium · Effort: Small · Reason not included: No user-visible impact; maintainability-only improvement that deserves its own focused commit. · Should become GitHub issue: No
DashboardTopbar date layout shift
Priority: Low · Effort: Small · Reason not included: Minor and intermittent; lower value than the heading hierarchy fix for today. · Should become GitHub issue: No
guest-search-filter.tsx custom dropdown — replace with Radix UI
Priority: Medium · Effort: Large · Reason not included: Large scope — multiple dropdowns need rework including accessibility and icon library migration; needs careful QA. · Should become GitHub issue: Yes
Large component file decomposition (guests-view, vendor-detail-panel, org-members-card)
Priority: Medium · Effort: Large · Reason not included: Cross-cutting refactor that requires careful split planning and regression testing. · Should become GitHub issue: Yes
Remove dead
@/path alias from tsconfig.jsonPriority: Low · Effort: Small · Reason not included: Developer-only, no user impact; can be batched with a future cleanup PR. · Should become GitHub issue: No
GitHub Issues Created or Proposed
No issues created today. The two Large recommendations (guest-search-filter Radix UI migration, large component decomposition) are candidates for future issues but were not filed — they need product/design input on scope before they're ready for structured tracking.
Generated by Claude Code