Repository navigation
dbeaver/pro#5910 fix: sorting only for result sets - #3506
Merged
Merged
Conversation
sergeyteleshev
previously approved these changes
Jun 4, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Limits column sorting to result-set data models only and verifies that the sorting action is supported before returning a sort state.
- Added a
supportedcheck onconstraintsAction - Added a guard to verify
isResultSetDataModel(model)
Comments suppressed due to low confidence (1)
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/DataGridTable.tsx:356
- Add unit tests for
getColumnSortingStateto cover the new guard: assert that it returnsnullwhenmodelis not a result-set or whenconstraintsAction.supportedis false, and returns the expected state otherwise.
if (!column || !constraintsAction?.supported || !isResultSetDataModel(model)) {
SychevAndrey
previously approved these changes
Jun 4, 2025
sergeyteleshev
approved these changes
Jun 4, 2025
Wroud
added a commit
that referenced
this pull request
Jun 4, 2025
* dbeaver/pro#5910 fix: sorting only for result sets * dbeaver/pro#5910 fix: require result set constraints only when needed
Wroud
added a commit
that referenced
this pull request
Jun 10, 2025
* dbeaver/pro#5910 fix: sorting only for result sets * dbeaver/pro#5910 fix: require result set constraints only when needed
Wroud
added a commit
that referenced
this pull request
Jun 10, 2025
…3502) * dbeaver/pro#5218 fix: limit websocket connection retry to 4 attempts * Update README.md - update contribution info (#3505) * dbeaver/pro#5910 fix: sorting only for result sets (#3506) * dbeaver/pro#5910 fix: sorting only for result sets * dbeaver/pro#5910 fix: require result set constraints only when needed * dbeaver/pro#5915 Delete legacy name service API usage + code style (#3510) * dbeaver/pro#5842 add validation for unset value (#3483) Co-authored-by: Daria Marutkina <125263541+dariamarutkina@users.noreply.github.com> --------- Co-authored-by: Anastasiya <45152336+LonwoLonwo@users.noreply.github.com> Co-authored-by: Serge Rider <serge@jkiss.org> Co-authored-by: alex <48489896+devnaumov@users.noreply.github.com> Co-authored-by: Daria Marutkina <125263541+dariamarutkina@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes dbeaver/pro#5910