Repository navigation
Bracket IPv6 hosts in the DSN shown and saved by \dsn - #2431
Merged
Merged
Conversation
format_connection_dsn wrote mysql://alice@::1:3307/prod, which urlparse cannot read back (port ':1:3307'), so a \dsn save alias for an IPv6 connection failed when used.
Contributor
|
Hi! Thanks for this! Merging #2430 has created a merge conflict with this PR. Would you like to fix that, or should I? |
Contributor
|
Should this be changed for prompt escapes too? |
Contributor
|
Released in https://github.com/dbcli/mycli/releases/tag/v2.31.0 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When connected to an IPv6 host,
\dsn showprintsmysql://alice@::1:3307/prodand\dsn savestores that string. The host isn't bracketed, so it can't be read back:urlparse(...).portraisesValueError: Port could not be cast to integer value as ':1:3307', and connecting with the saved alias fails incli_runner.format_connection_dsnnow wraps a host containing:in brackets, givingmysql://alice@[::1]:3307/prod.urlparsereturns hostname::1and port 3307 for that, which is what the connect path already expects.I added
test_format_connection_dsn_brackets_ipv6_host. It fails on main and passes with the fix. The rest ofmycli_testhas the same 63 failures with and without the change on my machine (polars/llm/repl tests that need extras or a server).Checklist
changelog.mdfile.mycli/AUTHORS.txtfile (or it's already there).