Repository navigation
improve mobile responsiveness & add table legend - #6
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances mobile responsiveness across several views and introduces a table legend for clarity in the team table display.
- Adjusts width calculations and adds overflow settings in ViewerView.vue and Tournament/SingleView.vue.
- Adds ellipsis styling in TeamTableEntry.vue.
- Introduces a table legend and responsive grid adjustments in TeamTable.vue, with additional mobile-specific header styling in App.vue.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/ViewerView.vue | Adjusted width and overflow for mobile responsiveness. |
| src/views/Tournament/SingleView.vue | Adjusted width and overflow for mobile responsiveness. |
| src/components/TeamTableEntry.vue | Added ellipsis styling for team names; suggestion to improve CSS for text truncation. |
| src/components/TeamTable.vue | Introduced a table legend; ensured grid layout adapts on small screens. |
| src/App.vue | Updated header style for mobile devices. |
|
|
||
| .name { | ||
| text-overflow: ellipsis; | ||
| overflow: hidden; |
There was a problem hiding this comment.
For text-overflow: ellipsis to work properly, consider adding 'white-space: nowrap' to the '.name' style to prevent wrapping.
Suggested change
| overflow: hidden; | |
| overflow: hidden; | |
| white-space: nowrap; |
| :tournament="tournament" | ||
| :teamMatchesRouteName="teamMatchesRouteName" | ||
| /> | ||
| <legend> |
There was a problem hiding this comment.
The element is intended for use within a
for grouping form elements. Consider replacing with a more semantically appropriate element like a.
Suggested change
| <legend> | |
| <div class="legend-container"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.