Skip to content

Refactor/perf batch 10 - #512

Open
timcadman wants to merge 28 commits into
v7.0-devfrom
refactor/perf-batch-10
Open

timcadman wants to merge 28 commits into
v7.0-devfrom
refactor/perf-batch-10

Conversation

@timcadman

@timcadman timcadman commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What's changed

Aside from the standard refactor:

  • isValidDS / .checkDisclosureSize: isValidDS(x) now takes a name, for the client. The old logic moved unchanged into the internal .checkDisclosureSize(obj), which server functions that already hold the object call directly (replaceNaDS, quantileMeanDS, rowColCalcDS, recodeLevelsDS).
  • tableDS force.nfilter / exclude: these are literal values, not object names, so they're converted directly with no .loadServersideObject. NA in exclude now always means missing; before, it only did when it was the sole value.
  • lexisDS2 carried-forward variables: built by loading each name, reproducing data.frame()'s column naming (D$varD.var). Checked identical to the old eval(parse()) output.
  • lexisDS2 entryCol = NULL: now defaults entry times to 0, as documented. It never worked before.
  • getWGSRDS: numeric only, and thirdPart is checked only for bfa, both matching the old client check.

@timcadman
timcadman changed the base branch from v6.3.6-dev to v7.0-dev September 15, 2026 19:31
@timcadman
timcadman marked this pull request as ready for review September 21, 2026 11:34

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing setting ot PERF.PROFILE env variable", hoping it will be complete in 10min.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants