Conversation
timcadman
marked this pull request as ready for review
September 21, 2026 11:34
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Fixing setting ot PERF.PROFILE env variable", hoping it will be complete in 10min.
Refactor/perf batch 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Aside from the standard refactor:
isValidDS/.checkDisclosureSize:isValidDS(x)now takes a name, for the client. The old logic moved unchanged into the internal.checkDisclosureSize(obj), which server functions that already hold the object call directly (replaceNaDS,quantileMeanDS,rowColCalcDS,recodeLevelsDS).tableDSforce.nfilter/exclude: these are literal values, not object names, so they're converted directly with no.loadServersideObject.NAinexcludenow always means missing; before, it only did when it was the sole value.lexisDS2carried-forward variables: built by loading each name, reproducingdata.frame()'s column naming (D$var→D.var). Checked identical to the oldeval(parse())output.lexisDS2entryCol = NULL: now defaults entry times to 0, as documented. It never worked before.getWGSRDS: numeric only, andthirdPartis checked only forbfa, both matching the old client check.