Skip to content

_repr_html_ should be placed in Fetch #186

Closed
Closed
_repr_html_ should be placed in Fetch#186
Assignees
fabiansinz

Description

@eywalker
eywalker
opened on Jan 26, 2016

Currently _repr_html_ is implemented in the RelationalOperand. This causes the fetch execution to occur when you typein the name of the RelationalOperand (and its derivatives) in IPython/Jupyter notebook. This is in disagreement with the rest of the repr behavior, where we only fetch and preview table content for repr in the Fetch object. Shall we move _repr_html_ into Fetch and Fetch1 to be more consistent with the rest?

Activity

  1. eywalker
    assigned
    eywalker
    and
    fabiansinz
    and unassigned
    eywalker
    on Jan 26, 2016
  2. eywalker
    added a commit that references this issue on Feb 26, 2016

    Merge pull request #189 from fabiansinz/master

    218b483

  3. fabiansinz commented on Apr 28, 2016

    @fabiansinz
    fabiansinz
    on Apr 28, 2016
    Contributor

    I guess we can close this issues because now both __repr__ and _repr_html_ cause a fetch operation. Even though this is not in agreement with the idea that only the fetch object should fetch data, it reduces the effort of typing .fetch everytime we would like to see some content of the table.

  4. dimitri-yatsenko commented on Jun 15, 2016

    @dimitri-yatsenko
    dimitri-yatsenko
    on Jun 15, 2016
    Member

    Now RelationalOperand has the preview method. RelationalOperand.__repr__ calls preview() when not in debug mode.

    Closing.

  5. dimitri-yatsenko
    closed this as completedon Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions