Skip to content

Add .gitattributes - #286

Merged
mumoshu merged 1 commit into
databus23:masterfrom
jkroepke:patch-2
Jan 8, 2022
Merged

mumoshu merged 1 commit into
databus23:masterfrom
jkroepke:patch-2

Conversation

@jkroepke

@jkroepke jkroepke commented Jun 7, 2021 •

Copy link
Copy Markdown
Contributor

If helm install is running on cygwin, an error occurred:

# Installed plugin: secrets
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 2: $'\r': command not found
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 4: $'\r': command not found
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 8: $'\r': command not found
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 9: C:\hostedtoolcache\windows\helm\3.6.0\x64\windows-amd64\helm.exe: command not found
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 10: $'\r': command not found
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 12: $'\r': command not found
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 17: $'\r': command not found
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 28: syntax error near unexpected token `$'{\r''
# D:\a\helm-secrets\helm-secrets\tests\.tmp\cache\CYGWIN_NT-10.0\helm\home\helm\plugins\helm-diff/install-binary.sh: line 28: `initArch() {
'
# Error: plugin install hook for "diff" exited with error

To prevent auto crlf on shell scripts, I added a .gitattributes file.

See also:
https://techblog.dorogin.com/case-of-windows-line-ending-in-bash-script-7236f056abe

@stale

stale Bot commented Sep 6, 2021

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Sep 6, 2021
@jkroepke

Copy link
Copy Markdown
Contributor Author

.

@stale stale Bot removed the stale label Sep 13, 2021
@stale

stale Bot commented Jan 3, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Jan 3, 2022

@mumoshu mumoshu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stale stale Bot removed the stale label Jan 8, 2022
@mumoshu
mumoshu merged commit 12d7955 into databus23:master Jan 8, 2022
@jkroepke
jkroepke deleted the patch-2 branch January 8, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants