Deprecate legacy skill configuration - #487
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new deprecation warning message can mislead users because ucode skill add requires --location, so the warning should clarify the utility-tools-only (no --location) case.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR deprecates the legacy ucode configure skills command to reduce confusion with the newer additive ucode skill add / ucode skill remove workflow, while preserving legacy behavior for existing scripts.
Changes:
- Marked
ucode configure skillsas deprecated and added a runtime migration warning. - Added CLI test coverage to ensure the deprecated command still dispatches to the legacy implementation.
- Reorganized README “Skills” documentation around
ucode skill add/ucode skill remove, keepingconfigure skillsas a compatibility note.
File summaries
| File | Description |
|---|---|
src/ucode/cli.py |
Deprecates configure skills and prints a migration warning; expands skill remove docstring. |
tests/test_cli.py |
Adds a regression test ensuring the deprecated command warns and still dispatches. |
README.md |
Updates Skills documentation to present skill add/remove as the primary workflow and notes configure skills as deprecated. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
baa430a to
92e359d
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The new deprecation warnings risk misleading users about migration semantics (replacement vs additive scope behavior) and should be clarified before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
| print_warning( | ||
| "`ucode configure skills` is deprecated. Use `ucode skill add` to download " | ||
| "skills or add MCP scopes, and `ucode skill remove --mcp` to remove MCP scopes." | ||
| ) |
| print_warning( | ||
| "`ucode configure skills` is deprecated, but its bare utility-tools-only setup " | ||
| "has no replacement yet and remains supported." | ||
| ) |
Why
After additive add and interactive removal exist,
ucode configure skillsoverlaps with the new workflow but has replacement semantics. Keeping both as equally prominent entry points makes it unclear which command developers should use.What changed
This PR marks
ucode configure skillsas deprecated and reorganizes the README arounducode skill addanducode skill remove.How it works
Builds on agent-specific removal in #486.
Testing
uv run pytest tests/test_skills_download.py tests/test_mcp.py tests/test_cli.py -q— 514 passeduv run ruff check .uv run ty check src/Tests verify both migration and utility-only warnings and confirm that the compatibility command still dispatches to its existing implementation.
Stack created with GitHub Stacks CLI • Give Feedback 💬